Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about Thwimp and Encoding THP with a new subvideo causes ridiculously high framerates?? #17

Open
AaronRules5 opened this issue Jul 27, 2021 · 0 comments

Comments

@AaronRules5
Copy link

AaronRules5 commented Jul 27, 2021

Hello there!

I just started using Thwimp in order to attempt to mod Mario Kart Wii.
I got all the files I needed for Thwimp, and set up the configuration correctly.

I first decided to try and rip a THP into MP4s and then re-encode it into a THP to know if it works correctly.
So I ripped all battle\battle_select.thp subvideos individually, and renamed them from:

  1. "battle_select_A1.mp4" to "battle_select_A1_1.mp4"
  2. "battle_select_A2.mp4" to "battle_select_A2_1.mp4"

Notice: It seems like I have to rip each subvideo manually in order for the re-encode to work afterwards.
Ripping a THP into a single MP4 by selecting "All" in the Special Presets instead of ripping each subvideo individually
seems to make re-encoding not possible. If I am wrong in this assessment please let me know!
It would be nice to not have to rip each one individually for re-encoding.
Perhaps I can do it in batch through the CLI mode, but I may not want to have to do that.

Anyway I did this and it seemed to work perfectly fine.
It ripped each subvideo fine, and I was able to re-encode into a new THP!

Problem is when I tried editing one of the subvideos.

I'm not sure which editing software you use to create/edit subvideos yourself but this is what I did...

  1. I put the original subvideo in VEGAS Pro 17.
  2. I created a new track with a test video, and resized it to fit the screen via Track Motion.
  3. I then tried rendering to 496x120 59.94fps. Vegas only let me render at a minimum of 496x144.
  4. I then put the new rendered video into Handbrake.
  5. I changed the dimensions from 496x144 to 496x120, and removed any automatic cropping.
  6. I removed the empty audio track in handbrake so there wouldn't be any audio track.
  7. I set the framerate to a constant 59.94 fps
  8. I set the average bitrate to 451 kbps.
  9. I then exported it to a new mp4.

Once done, I renamed this newly crafted mp4 to "battle_select_A2_1.mp4" and replaced the original subvideo.
I then finally tried encoding a THP with this new subvideo. (I left all the options for encoding set to default.)
FFmpeg opened and...

https://ibb.co/vs3yc3C

That can't be good...

This goes on for a while and even gets into the millions of frames so I pressed "q" to cancel it.

This is the properties for the first unedited subvideo "battle_select_A1_1.mp4":
https://ibb.co/JsgqWJ2

This is the properties for the second edited subvideo "battle_select_A2_1.mp4":
https://ibb.co/0cD1kdP

I tried to keep them as similar as possible. I'm not sure what the issue is.
Here's the edited MP4: https://www.file.io/download/xYDvwkJhNmej

One more question... is "multiplicity" kind of like... the number of subvideos... inside subvideos?
I just started using this tool so it's a lot to take in...

I may initiate a pull request to fix some of the issues I have with the program myself if you're busy.

Let me know if you can help me out with my issue or answering my questions! ❤️

P.S. Can you please keep the deleting of temporary files to a minimum? Make it optional to delete them via checkbox?
My first time trying out the software I ran the encode on my desktop and there are a bunch of files on my desktop.
It definitely deleted some of my JPGs and possibly MP4s I had on my desktop.
Luckily I don't think any of them are too important to me but still...
Maybe add a warning to the user guide or something...

@Tamk1s Tamk1s mentioned this issue May 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant