Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded column-names #1

Closed
frankcorneliusmartin opened this issue Nov 25, 2021 · 2 comments
Closed

hardcoded column-names #1

frankcorneliusmartin opened this issue Nov 25, 2021 · 2 comments

Comments

@frankcorneliusmartin
Copy link

The event and time column names are hardcoded in the Alice class:

return self.data["time"].loc[self.data["event"].astype(bool)].nunique()

self._data = self.data.sort_values(
by=["time", "event"], ascending=[True, False]
)

Would it be possible to have these settable on initialization?

@ThomasTNO
Copy link
Member

Nice suggestion, Frank! Thanks.

We will process this and release a new version.

The release will take place together with new releases of some (nested) dependencies.

@ThomasTNO
Copy link
Member

Solved in 630682f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants