Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape button shouldn't be a list item #196

Closed
BryceStevenWilley opened this issue Sep 25, 2023 · 0 comments · Fixed by #233
Closed

Escape button shouldn't be a list item #196

BryceStevenWilley opened this issue Sep 25, 2023 · 0 comments · Fixed by #233
Labels
accessibility bug Something isn't working

Comments

@BryceStevenWilley
Copy link
Contributor

Currently, the escape button shows up in the nav bar as a list item (<li>), not in any surrounding HTML list. This is generally an accessibility issue, as screen readers don't know how to handle list items just hanging around like that, and also has the default bullet, visible with different nav bar background colors (seen below).

A screenshot of the docassemble nav bar. The background is dark blue, there is a court forms online logo, and very close to the logo is a black bullet point, and a red escape button

Easy fix should be simple; just make a div instead of an li. There might be better HTML for that, but not sure of it off the top of my head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant