-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape button shouldn't be a list item #196
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the escape button shows up in the nav bar as a list item (
<li>
), not in any surrounding HTML list. This is generally an accessibility issue, as screen readers don't know how to handle list items just hanging around like that, and also has the default bullet, visible with different nav bar background colors (seen below).Easy fix should be simple; just make a
div
instead of anli
. There might be better HTML for that, but not sure of it off the top of my head.The text was updated successfully, but these errors were encountered: