Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Enable strict Typescript #552

Open
jordisala1991 opened this issue Jul 26, 2022 · 2 comments
Open

[Improvement]: Enable strict Typescript #552

jordisala1991 opened this issue Jul 26, 2022 · 2 comments

Comments

@jordisala1991
Copy link
Member

It is recommended using strict mode of Typescript.

It allows to catch bugs on typings, and avoids use of any around the code.

@jordisala1991
Copy link
Member Author

jordisala1991 commented Jul 26, 2022

You can enable those checks one by one:

"noImplicitAny": true,
"noImplicitThis": true,
"alwaysStrict": true,
"strictBindCallApply": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true

Or with the strict flag:

"strict": true

Since the project is big enough, it should be enabled step by step, to avoid huge PRs.

@jordisala1991
Copy link
Member Author

we are only missing:

"noImplicitAny": true,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant