Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

찜하기 기능 구현 #139

Merged
merged 13 commits into from
Nov 4, 2023
Merged

찜하기 기능 구현 #139

merged 13 commits into from
Nov 4, 2023

Conversation

1jeongg
Copy link
Member

@1jeongg 1jeongg commented Nov 3, 2023 •
edited
Loading

DONE

  • 찜하기 추가하기
  • 찜하기 취소하기
  • 찜하기 모아보기
  • 포트폴리오 전체 게시글, 상세 게시글, self 조회 게시글에 isLiked 필드 추가
  • 결제 코드에서 사용 안하는 API 삭제
  • 찜하기 테스트 코드 작성
  • 결제 테스트 코드 작성
  • 찜하기 모아보기에 이미지 추가 (이미지 저장 로직 정해지고 나면)

TODO

  • 회원가입, 로그인 시 userId 반환

close #138

@1jeongg
feat: remove unused payment apis
60c49d9 
- 사용하지 않는 결제 관련 API 삭제(검증, 업그레이드 API)
@1jeongg
feat: implement favorites apis
8f48117 
- 찜하기, 찜 취소하기, 모아보기 api 구현
- todo: 이미지 관련 코드 추가 필요
@1jeongg
feat: add isLiked field in getPortfolio dtos
2abc9d8
@1jeongg
refactor: user role exception removed
a6fd5ad
@1jeongg
feat: add authentication for review and favorites
aa5c036 
- 리뷰와 찜하기 기능에서 유저 인증 필수
@1jeongg 1jeongg added enhancement New feature or request Done 진행 완료 favorites labels Nov 3, 2023
@1jeongg 1jeongg self-assigned this Nov 3, 2023
chaee813
chaee813 approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@chaee813 chaee813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

찜하기 전체 구현부터 리팩토링까지,, 너무 고생 많으셨어요 !! 👍👍

@chaee813 chaee813 merged commit 1e6e76d into Step3-kakao-tech-campus:weekly Nov 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaee813 chaee813 chaee813 approved these changes

@seokwns seokwns Awaiting requested review from seokwns

Assignees

@1jeongg 1jeongg

Labels
Done 진행 완료 enhancement New feature or request favorites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

찜하기 기능 구현
2 participants
@1jeongg @chaee813