-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split game-specific protobufs into separate dlls #940
Labels
Comments
If we split DLLs we should probably also have a NuGet package per game, at which point we may have to be a little more careful about bincompat. |
With an actually-working version of .NET trimming, the trimming solves the problem for apps that make use of trimming. Unfortunately at the moment trimming breaks everything - #1057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
They're quite large, and not needed for SteamKit itself (only few generic GC protos are needed).
At which point, it could just be automatically updated with a cron action.
If there's one dll (nuget package?) per game, consumers can only include what they actually need.
Currently steamkit.dll is 5.4mb, removing all game protos makes it 1.5mb
The text was updated successfully, but these errors were encountered: