-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depotmanifest.Serialize() should be made public. #1354
Labels
Comments
Serialize() should accept a Stream (which removes the internal MemoryStream), and then SaveToFile can pass the file stream directly in, and then an overload can be added like SaveToStream (for consistency) which just calls Serialize. PRs welcome. |
I've implemented a potential solution for this. Please see PR #1337 for a minimalistic approach that addresses the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem is this feature trying to solve?
Currently, the only way to save DepotManifest is using
SaveToFile()
, makingSerialize()
public would allow alternatives.How would you like it to be solved?
Make the
Serialize()
function in DepotManifest public.Have you considered any alternative solutions
No.
Additional Information
No response
The text was updated successfully, but these errors were encountered: