Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KeyValue implementation with ValveKeyValue library #1289

Open
xPaw opened this issue Nov 4, 2023 · 2 comments
Open

Replace KeyValue implementation with ValveKeyValue library #1289

xPaw opened this issue Nov 4, 2023 · 2 comments

Comments

@xPaw
Copy link
Member

xPaw commented Nov 4, 2023

Depends on ValveResourceFormat/ValveKeyValue#30

Would have to figure out how to do it in a way to reduce breaking changes.

Fixes #258

@yaakov-h
Copy link
Member

yaakov-h commented Nov 4, 2023

We could probably write a wrapper that keeps the old KeyValue API and flag it with a warning-class [Obsolete] attribute, to give consumers some time to migrate?

Do we need to keep binary compatibility, source compatibility, or neither-but-make-it-easy?

@xPaw
Copy link
Member Author

xPaw commented Nov 4, 2023

Binary compat sounds like a bad idea considering we're going for .net 8 anyway.

And some SK apis use KeyValues so I'm not sure how obsolete helps if you can't migrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants