[BugFix] Fix repeated migration of colocate tablets

[mxdzs0612]

Co-authored-by: miomiocat [email protected]

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
• This is a backport pr

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.4
  • 3.3
  • 3.2
  • 3.1
  • 3.0

[starrocks-cr]

The most risky bug in this code is:
The changes are adding calls to olapTable.needSchedule() and olapTbl.needSchedule(), leading to skipped iterations when scheduling is not needed. If needSchedule logic is incorrect, or if skipping these parts without proper handling causes data imbalance or system performance issues, it may introduce a risk of improperly balanced clusters or missed scheduling opportunities.

You can modify the code like this:

// Assess if the conditions under which 'needSchedule' returns false might lead to critical operations being skipped inadvertently,
// and ensure that either strategic logging or alternative operations handle such cases to preserve cluster health.
private List<TabletSchedCtx> balanceClusterDisk(ClusterLoadStatistic clusterStat) {
    for (/* iteration variables */) {
        if (!olapTable.needSchedule(false)) {
            // Add logging or checks to confirm skipping doesn't cause issues
            continue;
        }
        if (isDestBackendLocationMismatch(olapTable, hBackend.getId(), lBackend.getId(),
                physicalPartition.getParentId(), tabletId)) {
            continue;
        }
        // rest of the function...
    }
}

private void balanceBackendDisk(TStorageMedium medium, double avgUsedPercent) {
    for (/* iteration variables */) {
        if (olapTable == null) {
            continue;
        }
        if (!olapTable.needSchedule(true)) {
            // Add logging or checks to assess impact
            continue;
        }
        if (isTabletUnhealthy(tabletMeta.getDbId(), olapTable, tabletId, tabletMeta, aliveBeIds)) {
            continue;
        }
        // rest of the function...
    }
}

private Map<Pair<Long, Long>, PartitionStat> getPartitionStats(TStorageMedium medium, boolean isLocalBalance) {
    for (/* iteration variables */) {
        if (!olapTbl.needSchedule(isLocalBalance)) {
            // Consider implementing fallback checks here
            continue;
        }
        for (Partition partition : globalStateMgr.getLocalMetastore().getAllPartitionsIncludeRecycleBin(olapTbl)) {
            partitionChecked++;
            if (partitionChecked % partitionBatchNum == 0) {
                // additional logic...
            }
        }
        // rest of the function...
    }
}

Ensure you validate whether operations that are bypassed should still partially execute or trigger alerts/logs for evaluation.

[sonarcloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

[FE Incremental Coverage Report]

❌ fail : 3 / 6 (50.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/clone/DiskAndTabletLoadReBalancer.java	3	6	50.00%	[558, 808, 1659]

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)