[Enhancement]Support select_if in arm #53093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: before-Sunrise <[email protected]>
Signed-off-by: before-Sunrise <[email protected]>
| } | ||
|
|
||
| template <typename T, bool left_const = false, bool right_const = false> | ||
| inline void neon_select_if_common_implement(uint8_t*& selector, T*& dst, const T*& a, const T*& b, int size) { |
There was a problem hiding this comment.
why need a const T*& ? can it be simplify as a const T* or even const void* ?
There was a problem hiding this comment.
why need a
const T*&? can it be simplify as aconst T*or evenconst void*?
because outside need to handle left data if size % 16 !=0
There was a problem hiding this comment.
you can add std::enable_if here to ensure that your template won't be instantiated with unexpected types
| } | ||
|
|
||
| uint8x16_t index = {0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 1, 1}; | ||
| uint8x16_t mask = vqtbl1q_u8(loaded_mask, index); |
There was a problem hiding this comment.
this piece of code is almost same exception the data_size parameter, it's better to extract the common part
Signed-off-by: before-Sunrise <[email protected]>
Signed-off-by: before-Sunrise <[email protected]>
Signed-off-by: before-Sunrise <[email protected]>
stdpain
approved these changes
Nov 22, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Benchmark for uint8_t (100000000 elements):
SIMD time: 15.9133 ms
Non-SIMD time: 290.615 ms
Speedup: 18.2624x
Benchmark for int16_t (100000000 elements):
SIMD time: 27.9742 ms
Non-SIMD time: 295.018 ms
Speedup: 10.5461x
Benchmark for int32_t (100000000 elements):
SIMD time: 51.5047 ms
Non-SIMD time: 291.931 ms
Speedup: 5.66804x
Benchmark for int64_t (100000000 elements):
SIMD time: 98.8005 ms
Non-SIMD time: 290.183 ms
Speedup: 2.93706x
Benchmark for double (100000000 elements):
SIMD time: 97.1446 ms
Non-SIMD time: 291.176 ms
Speedup: 2.99734x
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: