Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix shaded partition when manually added (backport #52894) #52993

Open
wants to merge 1 commit into
base: branch-3.1
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2024

Why I'm doing:

What I'm doing:

The SingleItemListPartitionDesc was used to represent single-column list partition, like PARTITION BY LIST(c).
But somehow it's misused in many places so current single-column list partition may also use the MultiItem.
This inconsistency can lead to serious bugs like the query result would be incorrect.

For example, if using both INSERT VALUES and ADD PARTITION to create partitions, the second form may be shaded during partition pruning.

The plan to fix it:

  1. Step one is to trying to convert SingleItem to MultiItem when adding new partitions if it's already a MultiItem
  2. Step two Remove the SingleItem and change all metadata when reloading metadata

This PR focus on the step one.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52894 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

The SingleItemListPartitionDesc was used to represent single-column list partition, like PARTITION BY LIST(c).
But somehow it's misused in many places so current single-column list partition may also use the MultiItem.
This inconsistency can lead to serious bugs like the query result would be incorrect.

For example, if using both INSERT VALUES and ADD PARTITION to create partitions, the second form may be shaded during partition pruning.

The plan to fix it:

  1. Step one is to trying to convert SingleItem to MultiItem when adding new partitions if it's already a MultiItem
  2. Step two Remove the SingleItem and change all metadata when reloading metadata

This PR focus on the step one.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: Murphy <[email protected]>
(cherry picked from commit c489466)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AlterTableClauseVisitor.java
Copy link
Contributor Author

mergify bot commented Nov 19, 2024

Cherry-pick of c489466 has failed:

On branch mergify/bp/branch-3.1/pr-52894
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit c48946634e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/ListPartitionInfo.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/ast/AddPartitionClause.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/ast/SingleItemListPartitionDesc.java
	new file:   test/sql/test_list_partition/R/test_add_list_partition
	new file:   test/sql/test_list_partition/T/test_add_list_partition

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AlterTableClauseVisitor.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Nov 19, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant