[BugFix] fix shaded partition when manually added (backport #52894) #52993
+503
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
The
SingleItemListPartitionDesc
was used to represent single-column list partition, likePARTITION BY LIST(c)
.But somehow it's misused in many places so current single-column list partition may also use the MultiItem.
This inconsistency can lead to serious bugs like the query result would be incorrect.
For example, if using both
INSERT VALUES
andADD PARTITION
to create partitions, the second form may be shaded during partition pruning.The plan to fix it:
This PR focus on the step one.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #52894 done by [Mergify](https://mergify.com). ## Why I'm doing:
What I'm doing:
The
SingleItemListPartitionDesc
was used to represent single-column list partition, likePARTITION BY LIST(c)
.But somehow it's misused in many places so current single-column list partition may also use the MultiItem.
This inconsistency can lead to serious bugs like the query result would be incorrect.
For example, if using both
INSERT VALUES
andADD PARTITION
to create partitions, the second form may be shaded during partition pruning.The plan to fix it:
This PR focus on the step one.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: