[BugFix] Support Generated Column rewrite for logical view with customize column name #52981
+173
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // use scope for view relation to analyze subqueryRelation, clear the pre-analyzed | ||
| // information first. | ||
| queryRelation.getGeneratedExprToColumnRef().clear(); | ||
| visitSubquery((SubqueryRelation) queryRelation, scope); | ||
| node.setGeneratedExprToColumnRef(queryRelation.getGeneratedExprToColumnRef()); | ||
| } else if (queryRelation instanceof SelectRelation) { | ||
| SelectRelation childSelectRelation = (SelectRelation) queryRelation; |
There was a problem hiding this comment.
The most risky bug in this code is:
Potential ClassCastException due to unsafe casting.
You can modify the code like this:
// Check instance of expected class before casting
Map<String, String> viewRefAlias = new HashMap<>();
if (scope.getRelationId().getSourceNode() instanceof ViewRelation) {
for (Field f : scope.getRelationFields().getAllFields()) {
if (f.getOriginExpression() instanceof SlotRef) {
viewRefAlias.put(((SlotRef) f.getOriginExpression()).getColumnName(), f.getName());
}
}
}
Map<SlotRef, String> slotRefToAlias = new HashMap<>();
for (SelectListItem item : childSelectRelation.getSelectList().getItems()) {
if (item.isStar()) {
slotRefToAlias.clear();
break;
}
if (!(item.getExpr() instanceof SlotRef)) {
continue;
}
SlotRef exprSlotRef = (SlotRef) item.getExpr();
if (!viewRefAlias.isEmpty()) {
String nameKey = exprSlotRef.getColumnName();
if (viewRefAlias.containsKey(nameKey)) {
slotRefToAlias.put(exprSlotRef, viewRefAlias.get(nameKey));
}
} else if (item.getAlias() != null && !item.getAlias().isEmpty()) {
slotRefToAlias.put(exprSlotRef, item.getAlias());
}
}This change ensures the cast is safe by storing the result of the cast in a variable and checking before using it further.
…mize column name Why I'm doing: In current implementation, if the logical view sepcify the customize column name which is different from the projection output of the SQL definition, optimizer will not rewrite Generated Column expression although all column have been outputed. This issue is caused by lack of alias information in SelectItem in this case. The alias information can be found in scope for logical view. What I'm doing: 1. Use alias information in scope for logical view rewriting. 2. Refactoring some code. Signed-off-by: srlch <[email protected]>
58b2485
to
e309a54
Compare
|
murphyatwork
approved these changes
Nov 19, 2024
Seaven
approved these changes
Nov 19, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 15 / 19 (78.95%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In current implementation, if the logical view sepecify the customize column name which is different from the projection output of the SQL definition, optimizer will not rewrite Generated Column expression although all column have been output.
This issue is caused by lack of alias information in SelectItem in this case. The alias information can be found in scope for logical view.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: