Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix unique/foreign contraints properties in lake table #52804

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Nov 11, 2024

Why I'm doing:

  • unique_constraints/foriegn_constraints cannot be shown in lake table.

What I'm doing:

  • put unique_constraints/foriegn_constraints properties into common properties.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing LiShuMing requested a review from a team as a code owner November 11, 2024 11:48
@github-actions github-actions bot added the 3.3 label Nov 11, 2024
Signed-off-by: shuming.li <[email protected]>
Copy link

sonarcloud bot commented Nov 11, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 13 / 13 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/OlapTable.java 13 13 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@LiShuMing LiShuMing changed the title [BugFix] Fix unique/foreign contraints properties [BugFix] Fix unique/foreign contraints properties in lake table Nov 12, 2024
@LiShuMing LiShuMing enabled auto-merge (squash) November 12, 2024 05:44
@LiShuMing LiShuMing merged commit 66e6471 into StarRocks:main Nov 12, 2024
59 checks passed
@LiShuMing LiShuMing deleted the fix/main/fix_uk_properties branch November 12, 2024 07:05
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 12, 2024
Copy link
Contributor

mergify bot commented Nov 12, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 12, 2024
wanpengfei-git pushed a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants