[BugFix] Fix analyzer exception for generated column rewrite #51755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why I'm doing: This problem is introduce by pr #StarRocks#50398. When we re-analyze the generated expression in current scope for subquery, sometime we may meet an exception. In current implementation, a map will be clear but the iteration does not break cause ConcurrentModificationException. What I'm doing: Remove the expression if re-analyze throw an exception instead of clear all generated column expression. Signed-off-by: srlch <[email protected]>
murphyatwork
approved these changes
Oct 11, 2024
Seaven
approved these changes
Oct 11, 2024
trueeyu
approved these changes
Oct 11, 2024
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 4 / 4 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
Signed-off-by: srlch <[email protected]> (cherry picked from commit f02fabf)
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
Signed-off-by: srlch <[email protected]> (cherry picked from commit f02fabf)
This was referenced Oct 11, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 12, 2024
…#51755) (#51805) Co-authored-by: srlch <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 12, 2024
…#51755) (#51806) Co-authored-by: srlch <[email protected]>
ZiheLiu
pushed a commit
to ZiheLiu/starrocks
that referenced
this pull request
Oct 31, 2024
…ks#51755) Signed-off-by: srlch <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…ks#51755) Signed-off-by: srlch <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
This problem is introduce by pr ##50398. When we re-analyze the generated expression in current scope for subquery, sometime we may meet an exception. In current implementation, a map will be clear but the iteration does not break cause ConcurrentModificationException.
What I'm doing:
Remove the expression if re-analyze throw an exception instead of clear all generated column expression.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: