Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add explain costs in query detail #51439

Merged
merged 2 commits into from
Sep 27, 2024
Merged

[Enhancement] add explain costs in query detail #51439

merged 2 commits into from
Sep 27, 2024

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Sep 26, 2024 •
edited
Loading

Why I'm doing:

EXPLAIN COSTS is much more useful to debug historical query, EXPLAIN usually is not enough.

What I'm doing:

  1. Generate a EXPLAIN COSTS in query detail instead of EXPLAIN
  2. Add a config query_detail_explain_level to control the behavior

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@murphyatwork murphyatwork requested review from a team as code owners September 26, 2024 07:07
satanson
satanson previously approved these changes Sep 26, 2024
View reviewed changes
Seaven
Seaven previously approved these changes Sep 26, 2024
View reviewed changes
kangkaisen
kangkaisen previously approved these changes Sep 26, 2024
View reviewed changes
@murphyatwork murphyatwork requested a review from a team as a code owner September 26, 2024 07:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 25 / 32 (78.12%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/StmtExecutor.java 8 13 61.54% [1170, 2105, 2106, 2107, 2108]
🔵 com/starrocks/sql/ast/StatementBase.java 8 10 80.00% [77, 81]
🔵 com/starrocks/common/Config.java 1 1 100.00% []
🔵 com/starrocks/sql/analyzer/AnalyzerUtils.java 7 7 100.00% []
🔵 com/starrocks/connector/parser/trino/AstBuilder.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit 92dfb5d into StarRocks:main Sep 27, 2024
55 of 56 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 27, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 27, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 27, 2024
@murphyatwork @mergify
[Enhancement] add explain costs in query detail (#51439)
e31c187 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 92dfb5d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/ast/StatementBase.java
mergify bot pushed a commit that referenced this pull request Sep 27, 2024
@murphyatwork @mergify
[Enhancement] add explain costs in query detail (#51439)
7fb3aab 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 92dfb5d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AnalyzerUtils.java
#	fe/fe-core/src/main/java/com/starrocks/sql/ast/StatementBase.java
This was referenced Sep 27, 2024
Merged
Merged
murphyatwork added a commit that referenced this pull request Oct 8, 2024
@murphyatwork
[Enhancement] add explain costs in query detail (#51439)
d1457e9 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 92dfb5d)
Signed-off-by: Murphy <[email protected]>

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/ast/StatementBase.java
murphyatwork added a commit that referenced this pull request Oct 8, 2024
@murphyatwork
[Enhancement] add explain costs in query detail (#51439)
b32218a 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 92dfb5d)
Signed-off-by: Murphy <[email protected]>

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AnalyzerUtils.java
#	fe/fe-core/src/main/java/com/starrocks/sql/ast/StatementBase.java
murphyatwork added a commit that referenced this pull request Oct 8, 2024
@murphyatwork
[Enhancement] add explain costs in query detail (#51439)
0ec2e4c 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 92dfb5d)
Signed-off-by: Murphy <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 8, 2024
@mergify @murphyatwork
[Enhancement] add explain costs in query detail (backport #51439) (#5…
63a4f3c 
…1480)

Co-authored-by: Murphy <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 8, 2024
@mergify @murphyatwork
[Enhancement] add explain costs in query detail (backport #51439) (#5…
1274bdb 
…1481)

Signed-off-by: Murphy <[email protected]>
Co-authored-by: Murphy <[email protected]>
@murphyatwork murphyatwork mentioned this pull request Oct 11, 2024
Merged
24 tasks
This was referenced Oct 11, 2024
Merged
Merged
@zombee0 zombee0 mentioned this pull request Oct 11, 2024
Merged
24 tasks
This was referenced Oct 14, 2024
Merged
Merged
Merged
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@murphyatwork @renzhimin7
[Enhancement] add explain costs in query detail (StarRocks#51439)
a786d8f 
Signed-off-by: Murphy <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-shelby stephen-shelby stephen-shelby approved these changes

@Youngwb Youngwb Youngwb approved these changes

@Seaven Seaven Seaven approved these changes

@satanson satanson satanson approved these changes

@kangkaisen kangkaisen kangkaisen left review comments

Assignees

@murphyatwork murphyatwork

Labels
3.2-merged 3.3-merged behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@murphyatwork @satanson @Seaven @Youngwb @kangkaisen @stephen-shelby