Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Rewrite &>> in a portable way #50516

Merged

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Sep 1, 2024

  • &>> is a bash4 feature, rewrite it as >> {file} 2>&1 for earlier version bash

Why I'm doing:

What I'm doing:

Fixes #50505

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

* `&>>` is a bash4 feature, rewrite it as `>> {file} 2>&1` for earlier
  version bash

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Copy link

github-actions bot commented Sep 1, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 1, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 1, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@alvin-celerdata alvin-celerdata merged commit b79f27e into StarRocks:main Sep 1, 2024
42 checks passed
Copy link

github-actions bot commented Sep 1, 2024

@Mergifyio backport branch-3.3

Copy link

github-actions bot commented Sep 1, 2024

@Mergifyio backport branch-3.2

Copy link

github-actions bot commented Sep 1, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 1, 2024
Copy link
Contributor

mergify bot commented Sep 1, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 1, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 1, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 1, 2024
&>> is a bash4 feature, rewrite it as >> {file} 2>&1 for earlier version bash

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit b79f27e)
mergify bot pushed a commit that referenced this pull request Sep 1, 2024
&>> is a bash4 feature, rewrite it as >> {file} 2>&1 for earlier version bash

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit b79f27e)
mergify bot pushed a commit that referenced this pull request Sep 1, 2024
&>> is a bash4 feature, rewrite it as >> {file} 2>&1 for earlier version bash

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit b79f27e)
wanpengfei-git pushed a commit that referenced this pull request Sep 1, 2024
wanpengfei-git pushed a commit that referenced this pull request Sep 1, 2024
wanpengfei-git pushed a commit that referenced this pull request Sep 4, 2024
xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request Sep 6, 2024
va-os-commits pushed a commit to va-os-commits/starrocks that referenced this pull request Sep 10, 2024
&>> is a bash4 feature, rewrite it as >> {file} 2>&1 for earlier version bash

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
@kevincai kevincai deleted the fix-stdout_stderr-redirect branch October 19, 2024 08:19
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
&>> is a bash4 feature, rewrite it as >> {file} 2>&1 for earlier version bash

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot start fe in Mac environment.
2 participants