[BugFix] Fix partition live number not update #49437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wyb <[email protected]>
kevincai
reviewed
Aug 6, 2024
|
kevincai
approved these changes
Aug 7, 2024
[FE Incremental Coverage Report]✅ pass : 4 / 4 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
alvin-celerdata
approved these changes
Aug 8, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
Why I'm doing:
alter table tbl set ("partition_live_number" = "2") can modify table partition live number,
but when FE restarts, partition_live_number will be recovered to old value.
buildPartitionLiveNumber checks the current value of partitionTTLNumber and does not update if it is not -1.
What I'm doing:
fix the update check.
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 889a910)
# Conflicts:
# fe/fe-core/src/main/java/com/starrocks/catalog/TableProperty.java
# fe/fe-core/src/test/java/com/starrocks/catalog/TablePropertyTest.java
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
Why I'm doing:
alter table tbl set ("partition_live_number" = "2") can modify table partition live number,
but when FE restarts, partition_live_number will be recovered to old value.
buildPartitionLiveNumber checks the current value of partitionTTLNumber and does not update if it is not -1.
What I'm doing:
fix the update check.
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 889a910)
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
Why I'm doing:
alter table tbl set ("partition_live_number" = "2") can modify table partition live number,
but when FE restarts, partition_live_number will be recovered to old value.
buildPartitionLiveNumber checks the current value of partitionTTLNumber and does not update if it is not -1.
What I'm doing:
fix the update check.
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 889a910)
This was referenced Aug 8, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: wyb <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: wyb <[email protected]>
wyb
added a commit
to wyb/starrocks
that referenced
this pull request
Aug 8, 2024
Why I'm doing:
alter table tbl set ("partition_live_number" = "2") can modify table partition live number,
but when FE restarts, partition_live_number will be recovered to old value.
buildPartitionLiveNumber checks the current value of partitionTTLNumber and does not update if it is not -1.
What I'm doing:
fix the update check.
Signed-off-by: wyb <[email protected]>
26 tasks
wyb
added a commit
that referenced
this pull request
Aug 8, 2024
Signed-off-by: wyb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
alter table tbl set ("partition_live_number" = "2")can modify table partition live number,but when FE restarts,
partition_live_numberwill be recovered to old value.buildPartitionLiveNumberchecks the current value ofpartitionTTLNumberand does not update if it is not-1.What I'm doing:
fix the update check.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: