Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support json logical type in parquet files() #49385

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Aug 5, 2024

Why I'm doing:

https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#json
In parquet, JSON is used for an embedded JSON document. It must annotate a BYTE_ARRAY primitive type.

currently, parquet schema builder returns varbinary type if logical type is json.

What I'm doing:

json type is supported in sr, so return json type

Fixes #43751

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb wyb requested a review from a team as a code owner August 5, 2024 08:13
@mergify mergify bot assigned wyb Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Aug 5, 2024

[BE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/parquet_schema_builder.cpp 2 2 100.00% []

@trueeyu trueeyu merged commit 914ca69 into StarRocks:main Aug 6, 2024
64 checks passed
Copy link

github-actions bot commented Aug 6, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Aug 6, 2024
Copy link
Contributor

mergify bot commented Aug 6, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Aug 6, 2024

backport branch-3.2

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants