-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Support json logical type in parquet files() #49385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wyb <[email protected]>
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
jaogoy
approved these changes
Aug 6, 2024
trueeyu
approved these changes
Aug 6, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
Signed-off-by: wyb <[email protected]> (cherry picked from commit 914ca69)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
Signed-off-by: wyb <[email protected]> (cherry picked from commit 914ca69)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 6, 2024
…49385) (#49424) Co-authored-by: wyb <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 8, 2024
…49385) (#49423) Co-authored-by: wyb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#json
In parquet, JSON is used for an embedded JSON document. It must annotate a BYTE_ARRAY primitive type.
currently, parquet schema builder returns
varbinary
type if logical type isjson
.What I'm doing:
json type is supported in sr, so return
json
typeFixes #43751
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: