Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix the bug that the backend of other clusters is added to the current cluster when synchronizing Olap external table metadata #49323

Conversation

gengjun-git
Copy link
Contributor

Why I'm doing:

PR #40982 remove the systemInfoMap from NodeMgr, so all the backends are added into the current cluster.

What I'm doing:

Store the external SystemInfoService into Olap External Table, and use it when loading into that table.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: gengjun-git <[email protected]>
@gengjun-git gengjun-git requested a review from a team as a code owner August 2, 2024 06:50
@github-actions github-actions bot added the 3.3 label Aug 2, 2024
Copy link

sonarcloud bot commented Aug 2, 2024

Copy link

github-actions bot commented Aug 2, 2024

[FE Incremental Coverage Report]

pass : 31 / 33 (93.94%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/planner/OlapTableSink.java 6 7 85.71% [738]
🔵 com/starrocks/catalog/ExternalOlapTable.java 13 14 92.86% [290]
🔵 com/starrocks/service/FrontendServiceImpl.java 10 10 100.00% []
🔵 com/starrocks/planner/SchemaTableSink.java 2 2 100.00% []

Copy link

github-actions bot commented Aug 2, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@nshangyiming nshangyiming merged commit c8c6fa0 into StarRocks:main Aug 7, 2024
49 checks passed
Copy link

github-actions bot commented Aug 7, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 7, 2024
Copy link
Contributor

mergify bot commented Aug 7, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 7, 2024
…he current cluster when synchronizing Olap external table metadata (#49323)

Signed-off-by: gengjun-git <[email protected]>
(cherry picked from commit c8c6fa0)
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
…he current cluster when synchronizing Olap external table metadata (backport #49323) (#49468)

Co-authored-by: gengjun-git <[email protected]>
trueeyu pushed a commit to trueeyu/starrocks that referenced this pull request Aug 14, 2024
…he current cluster when synchronizing Olap external table metadata (backport StarRocks#49323) (StarRocks#49468)

Co-authored-by: gengjun-git <[email protected]>
XinzhuangL added a commit to fl4me-starrocks/starrocks that referenced this pull request Aug 19, 2024
…he current cluster when synchronizing Olap external table metadata StarRocks#49323

Signed-off-by: XinzhuangL <[email protected]>
XinzhuangL added a commit to fl4me-starrocks/starrocks that referenced this pull request Aug 19, 2024
…he current cluster when synchronizing Olap external table metadata StarRocks#49323

Signed-off-by: XinzhuangL <[email protected]>
XinzhuangL added a commit to fl4me-starrocks/starrocks that referenced this pull request Aug 19, 2024
…he current cluster when synchronizing Olap external table metadata StarRocks#49323

Signed-off-by: XinzhuangL <[email protected]>
lmagic233 pushed a commit to lmagic233/starrocks that referenced this pull request Sep 19, 2024
…he current cluster when synchronizing Olap external table metadata (StarRocks#49323)

Signed-off-by: gengjun-git <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants