-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix the bug that the backend of other clusters is added to the current cluster when synchronizing Olap external table metadata #49323
Merged
nshangyiming
merged 1 commit into
StarRocks:main
from
gengjun-git:fix_olap_external_table_add_backend_bug
Aug 7, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gengjun-git <[email protected]>
Quality Gate passedIssues Measures |
[FE Incremental Coverage Report]✅ pass : 31 / 33 (93.94%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
HangyuanLiu
approved these changes
Aug 7, 2024
nshangyiming
approved these changes
Aug 7, 2024
@Mergifyio backport branch-3.3 |
✅ Backports have been created |
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
…he current cluster when synchronizing Olap external table metadata (#49323) Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit c8c6fa0)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 8, 2024
…he current cluster when synchronizing Olap external table metadata (backport #49323) (#49468) Co-authored-by: gengjun-git <[email protected]>
trueeyu
pushed a commit
to trueeyu/starrocks
that referenced
this pull request
Aug 14, 2024
…he current cluster when synchronizing Olap external table metadata (backport StarRocks#49323) (StarRocks#49468) Co-authored-by: gengjun-git <[email protected]>
XinzhuangL
added a commit
to fl4me-starrocks/starrocks
that referenced
this pull request
Aug 19, 2024
…he current cluster when synchronizing Olap external table metadata StarRocks#49323 Signed-off-by: XinzhuangL <[email protected]>
XinzhuangL
added a commit
to fl4me-starrocks/starrocks
that referenced
this pull request
Aug 19, 2024
…he current cluster when synchronizing Olap external table metadata StarRocks#49323 Signed-off-by: XinzhuangL <[email protected]>
XinzhuangL
added a commit
to fl4me-starrocks/starrocks
that referenced
this pull request
Aug 19, 2024
…he current cluster when synchronizing Olap external table metadata StarRocks#49323 Signed-off-by: XinzhuangL <[email protected]>
lmagic233
pushed a commit
to lmagic233/starrocks
that referenced
this pull request
Sep 19, 2024
…he current cluster when synchronizing Olap external table metadata (StarRocks#49323) Signed-off-by: gengjun-git <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
PR #40982 remove the systemInfoMap from NodeMgr, so all the backends are added into the current cluster.
What I'm doing:
Store the external SystemInfoService into Olap External Table, and use it when loading into that table.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: