[BugFix] Fix the bug in the persistent index that checks whether page reading is supported. #48659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sevev <[email protected]>
Signed-off-by: sevev <[email protected]>
luohaha
approved these changes
Jul 22, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 4 / 4 (100.00%) file detail
|
wyb
approved these changes
Jul 23, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
… reading is supported. (#48659) Signed-off-by: sevev <[email protected]> (cherry picked from commit cb6ef72)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
… reading is supported. (#48659) Signed-off-by: sevev <[email protected]> (cherry picked from commit cb6ef72)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
… reading is supported. (#48659) Signed-off-by: sevev <[email protected]> (cherry picked from commit cb6ef72)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 23, 2024
… reading is supported. (backport #48659) (#48747) Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 23, 2024
… reading is supported. (backport #48659) (#48746) Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 23, 2024
… reading is supported. (backport #48659) (#48745) Co-authored-by: zhangqiang <[email protected]>
dujijun007
pushed a commit
to dujijun007/starrocks
that referenced
this pull request
Jul 29, 2024
… reading is supported. (StarRocks#48659) Signed-off-by: sevev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Pindex support read by page in following scenarios:
There are the following scenarios:
uncompressed_sizeis 0uncompressed_sizeis 0uncompressed_sizeis greater than 0uncompressed_sizeis greater than 0 and each compressed page size is saved inpage_offSo when the
uncompressed_sizeis greater than 0, we need to separateshard-compressionandpage-compression. We will usepage_offto judge which compression type is used. So we need to setpage_offsas 0 when we upgrade from old version.What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: