Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Use copyOnlyForQuery instead of deepCopy to avoid time costs in mv refresh's collectBaseTableSnapshotInfos #48256

Merged
merged 2 commits into from
Jul 12, 2024
Merged

[BugFix] Use copyOnlyForQuery instead of deepCopy to avoid time costs in mv refresh's collectBaseTableSnapshotInfos #48256

merged 2 commits into from
Jul 12, 2024

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Jul 12, 2024 •
edited
Loading

Why I'm doing:

  • DeepCopy.copyWithGson is very time costing, use copyOnlyForQuery to reduce the cost.
2024-07-11 21:27:42.553+08:00 INFO (starrocks-taskrun-pool-8|2229) [PartitionBasedMvRefreshProcessor.collectBaseTables():1474] Collect base table snapshot infos for materialized view: , cost: 155289 ms
2024-07-11 21:32:30.110+08:00 INFO (starrocks-taskrun-pool-8|2229) [PartitionBasedMvRefreshProcessor.collectBaseTables():1474] Collect base table snapshot infos for materialized view:, cost: 180511 ms
2024-07-11 21:35:43.858+08:00 INFO (starrocks-taskrun-pool-7|2005) [PartitionBasedMvRefreshProcessor.collectBaseTables():1474] Collect base table snapshot infos for materialized view:, cost: 193695 ms

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing
Use copyOnlyForQuery instead of deepCopy to avoid time costs in mv re…
e9d7773 
…fresh's collectBaseTableSnapshotInfos

Signed-off-by: shuming.li <[email protected]>
@LiShuMing LiShuMing requested a review from a team as a code owner July 12, 2024 03:02
@LiShuMing
fix bugs
ae70112 
Signed-off-by: shuming.li <[email protected]>
@LiShuMing LiShuMing force-pushed the fix/main/fix_deep_copy_mv_refresh branch from 6f79cca to ae70112 Compare July 12, 2024 03:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 12, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 14 / 14 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java 12 12 100.00% []
🔵 com/starrocks/catalog/OlapTable.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@LiShuMing LiShuMing changed the title [UT] Use copyOnlyForQuery instead of deepCopy to avoid time costs in mv refresh's collectBaseTableSnapshotInfos [BugFix] Use copyOnlyForQuery instead of deepCopy to avoid time costs in mv refresh's collectBaseTableSnapshotInfos Jul 12, 2024
@LiShuMing LiShuMing merged commit af19cfb into StarRocks:main Jul 12, 2024
71 checks passed
@LiShuMing LiShuMing deleted the fix/main/fix_deep_copy_mv_refresh branch July 12, 2024 06:10
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jul 12, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jul 12, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Jul 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 12, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 12, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 12, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 12, 2024
@LiShuMing @mergify
[BugFix] Use copyOnlyForQuery instead of deepCopy to avoid time costs…
cc98730 
… in mv refresh's collectBaseTableSnapshotInfos (#48256)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit af19cfb)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/OlapTable.java
#	fe/fe-core/src/main/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java
@mergify mergify bot mentioned this pull request Jul 12, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jul 12, 2024
@LiShuMing @mergify
[BugFix] Use copyOnlyForQuery instead of deepCopy to avoid time costs…
af22e13 
… in mv refresh's collectBaseTableSnapshotInfos (#48256)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit af19cfb)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/OlapTable.java
#	fe/fe-core/src/main/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java
#	fe/fe-core/src/main/java/com/starrocks/scheduler/TableSnapshotInfo.java
mergify bot pushed a commit that referenced this pull request Jul 12, 2024
@LiShuMing @mergify
[BugFix] Use copyOnlyForQuery instead of deepCopy to avoid time costs…
5e69180 
… in mv refresh's collectBaseTableSnapshotInfos (#48256)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit af19cfb)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/OlapTable.java
#	fe/fe-core/src/main/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java
#	fe/fe-core/src/main/java/com/starrocks/scheduler/TableSnapshotInfo.java
This was referenced Jul 12, 2024
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Jul 12, 2024
@mergify @LiShuMing
[BugFix] Use copyOnlyForQuery instead of deepCopy to avoid time costs…
de61fae 
… in mv refresh's collectBaseTableSnapshotInfos (backport #48256) (#48270)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: shuming.li <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 12, 2024
@mergify @LiShuMing
[BugFix] Use copyOnlyForQuery instead of deepCopy to avoid time costs…
bf92798 
… in mv refresh's collectBaseTableSnapshotInfos (backport #48256) (#48271)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: shuming.li <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 15, 2024
@mergify @LiShuMing
[BugFix] Use copyOnlyForQuery instead of deepCopy to avoid time costs…
e5743ed 
… in mv refresh's collectBaseTableSnapshotInfos (backport #48256) (#48269)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: shuming.li <[email protected]>
smartlxh pushed a commit to smartlxh/starrocks that referenced this pull request Oct 16, 2024
@wxl24life @LiShuMing
[Backport][BugFix] Use copyOnlyForQuery instead of deepCopy to avoid …
8ec11a7 
…time costs in mv refresh's collectBaseTableSnapshotInfos (backport StarRocks#48256) (StarRocks#48270)

Link: https://code.alibaba-inc.com/soe/starrocks/codereview/17914626

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: shuming.li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

@Seaven Seaven Seaven approved these changes

@satanson satanson satanson approved these changes

Assignees

@LiShuMing LiShuMing

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiShuMing @satanson @Seaven @HangyuanLiu