[BugFix] Correct the profile for datacache write stats to represent the actual data statistics written to datacache (backport #48136) #48148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he actual data statistics written to datacache (#48136) Signed-off-by: Gavin <[email protected]> (cherry picked from commit 12c9b67)
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Now when writing data to cache, if it already exist, we still treat this write successful and add its statistics to the profile.
This will cause the metrics in the profile, such as
DataCacheWriteBytes, is confused and cannot represent the actual data that be written to cache.What I'm doing:
Ignore the statistics data for the
EEXISTstatus.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #48136 done by [Mergify](https://mergify.com). ## Why I'm doing: Now when writing data to cache, if it already exist, we still treat this write successful and add its statistics to the profile. This will cause the metrics in the profile, such as `DataCacheWriteBytes`, is confused and cannot represent the actual data that be written to cache.
What I'm doing:
Ignore the statistics data for the
EEXISTstatus.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: