Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Add max column table limit max_column_number_per_table for table #47869

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Refactor] Add max column table limit max_column_number_per_table for table #47869

merged 1 commit into from
Jul 23, 2024

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Jul 4, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@meegoo meegoo requested a review from a team as a code owner July 4, 2024 13:42
@meegoo meegoo changed the title [Refactor] Add max column table limit max_column_number_per_table for… [Refactor] Add max column table limit max_column_number_per_table for table Jul 4, 2024
@mergify mergify bot assigned meegoo Jul 4, 2024
@meegoo meegoo enabled auto-merge (squash) July 5, 2024 03:12
@meegoo meegoo requested a review from a team as a code owner July 8, 2024 15:13
@meegoo meegoo disabled auto-merge July 10, 2024 08:42
jaogoy
jaogoy previously approved these changes Jul 10, 2024
View reviewed changes
Seaven
Seaven previously approved these changes Jul 10, 2024
View reviewed changes
@meegoo meegoo dismissed stale reviews from Seaven and jaogoy via a240f8f July 10, 2024 09:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 3 / 4 (75.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/CreateTableAnalyzer.java 1 2 50.00% [192]
🔵 com/starrocks/common/Config.java 1 1 100.00% []
🔵 com/starrocks/common/ErrorCode.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@meegoo meegoo enabled auto-merge (squash) July 23, 2024 03:03
@wanpengfei-git wanpengfei-git merged commit db005eb into StarRocks:main Jul 23, 2024
48 of 50 checks passed
dujijun007 pushed a commit to dujijun007/starrocks that referenced this pull request Jul 29, 2024
@meegoo @dujijun007
[Refactor] Add max column table limit max_column_number_per_table for…
02fcd7f 
… table (StarRocks#47869)

Signed-off-by: meegoo <[email protected]>
@meegoo
Copy link
Contributor Author

meegoo commented Oct 11, 2024

@mergify backport branch-3.3 branch-3.2 branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024 •
edited
Loading

backport branch-3.3 branch-3.2 branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@meegoo @mergify
[Refactor] Add max column table limit max_column_number_per_table for…
71b80e6 
… table (#47869)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit db005eb)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
#	fe/fe-core/src/test/java/com/starrocks/sql/analyzer/CreateTableAnalyzerTest.java
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@meegoo @mergify
[Refactor] Add max column table limit max_column_number_per_table for…
c4bf5c9 
… table (#47869)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit db005eb)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/CreateTableAnalyzer.java
#	fe/fe-core/src/test/java/com/starrocks/sql/analyzer/CreateTableAnalyzerTest.java
This was referenced Oct 11, 2024
Merged
Closed
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@meegoo @mergify
[Refactor] Add max column table limit max_column_number_per_table for…
a0f023f 
… table (#47869)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit db005eb)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/CreateTableAnalyzer.java
#	fe/fe-core/src/test/java/com/starrocks/sql/analyzer/CreateTableAnalyzerTest.java
@mergify mergify bot mentioned this pull request Oct 11, 2024
Closed
42 tasks
meegoo added a commit that referenced this pull request Oct 13, 2024
@mergify @meegoo
[Refactor] Add max column table limit max_column_number_per_table for…
63532ed 
… table (backport #47869) (#51787)

Signed-off-by: meegoo <[email protected]>
Co-authored-by: meegoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@packy92 packy92 packy92 approved these changes

@jaogoy jaogoy jaogoy approved these changes

@Seaven Seaven Seaven left review comments

Assignees

@meegoo meegoo

Labels
3.3-merged behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meegoo @Seaven @jaogoy @packy92 @wanpengfei-git