[BugFix] Enable multi columns in global runtime filter by default #34884
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a1dc3d
to
2e3d5c5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
satanson
previously approved these changes
Jan 3, 2024
satanson
reviewed
Jan 3, 2024
| @@ -642,7 +642,7 @@ public static MaterializedViewRewriteMode parse(String str) { | |||
| private boolean runtimeFilterOnExchangeNode = false; | |||
|
|
|||
| @VariableMgr.VarAttr(name = ENABLE_MULTI_COLUMNS_ON_GLOBAL_RUNTIME_FILTER) | |||
| private boolean enableMultiColumnsOnGlobalRuntimeFilter = false; | |||
| private boolean enableMultiColumnsOnGlobalRuntimeFilter = true; | |||
There was a problem hiding this comment.
enable session variables in default should modify the code as follows:
@VariableMgr.VarAttr(name = ENABLE_PIPELINE, alias = ENABLE_PIPELINE_ENGINE, show = ENABLE_PIPELINE_ENGINE)
private boolean enablePipelineEngine = true;
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
2e3d5c5
to
2104e47
Compare
|
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: