Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix]Revert "[Enhancement] remove some useless operatitons when start as c… #32229

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[BugFix]Revert "[Enhancement] remove some useless operatitons when start as c… #32229

merged 1 commit into from
Oct 9, 2023

Conversation

abc982627271
Copy link
Contributor

@abc982627271 abc982627271 commented Oct 9, 2023 •
edited by sduzh
Loading

…n (#31947)"

This reverts commit 6b577c1.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@github-actions github-actions bot added the 3.2 label Oct 9, 2023
@wyb wyb enabled auto-merge (squash) October 9, 2023 02:54
auto-merge was automatically disabled October 9, 2023 07:08

Head branch was pushed to by a user without write access

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 9 / 12 (75.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/agent/heartbeat_server.cpp 0 1 00.00% [221]
🔵 src/storage/storage_engine.h 0 1 00.00% [268]
🔵 src/service/service_be/starrocks_be.cpp 0 1 00.00% [100]
🔵 src/storage/storage_engine.cpp 7 7 100.00% []
🔵 src/storage/data_dir.cpp 2 2 100.00% []

@wyb wyb merged commit bc5b64a into StarRocks:main Oct 9, 2023
32 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 9, 2023
@abc982627271 @mergify
[BugFix]Revert "[Enhancement] remove some useless operatitons when st…
83e5ec5 
…art as c… (#32229)

Signed-off-by: abc982627271 <[email protected]>
(cherry picked from commit bc5b64a)

# Conflicts:
#	be/src/storage/storage_engine.cpp
@mergify mergify bot mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduzh sduzh sduzh approved these changes

@wyb wyb wyb approved these changes

Assignees

@abc982627271 abc982627271

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abc982627271 @wanpengfei-git @wyb @sduzh