Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix UT PartitionBasedMvRefreshProcessorTest for paimon.Snappy #32211

Merged
merged 1 commit into from
Oct 8, 2023
Merged

[BugFix] fix UT PartitionBasedMvRefreshProcessorTest for paimon.Snappy #32211

merged 1 commit into from
Oct 8, 2023

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Oct 8, 2023 •
edited by miomiocat
Loading

Fixes #issue

The UT PartitionBasedMvRefreshProcessorTest depends on paimon, and implicitly depends on the Snappy.

Without this PR, running this UT would report Unrecognized codec: snappy exception.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
7.7% 7.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@murphyatwork murphyatwork enabled auto-merge (squash) October 8, 2023 11:45
@murphyatwork murphyatwork merged commit 05d6b1b into StarRocks:main Oct 8, 2023
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miomiocat miomiocat miomiocat approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@murphyatwork murphyatwork

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murphyatwork @wanpengfei-git @kangkaisen @miomiocat