Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-615] Removed molecule-testing artifact #616

Conversation

thederputy
Copy link
Contributor

Hello/bonjour, this PR updates the dependency notations for CashApp/Molecule.

What?

Resolves #615

Removes a dependency notation for an artifact that has been removed.

Why?

To stay in line with current artifacts in CashApp/Molecule

How?

Removed the dependency notation.

Testing?

  • Ran ./gradlew check
  • Published to maven local, and consumed in a project locally

@thederputy
Copy link
Contributor Author

thederputy commented Sep 18, 2022

Whoops, looks like I missed something before pushing. I'll investigate.

@thederputy thederputy marked this pull request as draft September 18, 2022 23:28
@LouisCAD
Copy link
Member

It's the [WIP] thing, because we try to group the removals. Remove it and that'll fix it.

@thederputy thederputy force-pushed the dependency/molecule-remove-testing-artifact branch from e900980 to 2f6ce32 Compare September 19, 2022 04:24
@thederputy thederputy marked this pull request as ready for review September 19, 2022 04:28
@thederputy
Copy link
Contributor Author

@LouisCAD fixed and updated. Thanks for the help!

@LouisCAD LouisCAD merged commit 1201894 into Splitties:main Sep 21, 2022
@LouisCAD
Copy link
Member

LouisCAD commented Sep 21, 2022

Merged locally and tweaked the removal comment to specify the exact version. Thank you!

@thederputy thederputy deleted the dependency/molecule-remove-testing-artifact branch September 21, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Dependency notations for CashApp/Molecule
2 participants