Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✎ Rewrite Overview & other documentation updates #269

Merged
merged 52 commits into from
Oct 18, 2020
Merged

✎ Rewrite Overview & other documentation updates #269

merged 52 commits into from
Oct 18, 2020

Conversation

jmfayard
Copy link
Member

@jmfayard jmfayard commented Oct 15, 2020

@LouisCAD please read the new Overview page
and maybe let's discuss it by phone

https://jmfayard.github.io/refreshVersions/

@jmfayard jmfayard changed the title mkdocs ✎ Rewrite Overview & other documentation updates Oct 15, 2020
@LouisCAD
Copy link
Member

I'll review it this weekend. I need to release 0.9.7 properly (and the release process needs to be updated now that we got the website), and then I need to sleep and finish the office week.

@LouisCAD LouisCAD self-assigned this Oct 15, 2020
@LouisCAD
Copy link
Member

@jmfayard Can you get PRs and the non main branch to deploy on another base url so we don't impact the production site that can be updated by new releases happening on the main branch?

mkdocs.yml Outdated Show resolved Hide resolved
@jmfayard
Copy link
Member Author

For the README, once we are happy with the website, I am inclined to do like runningcode and replace it with a big link to the documentation. Very effective remedy to the "people don't click on link" issue

image

@LouisCAD
Copy link
Member

Everything but the contributing docs should be alright (their content is TK following convention in the newspaper industry, to easily find it back).

I need to sleep now, so I'll leave it to later.

Here's the full guide I had started: https://github.com/jmfayard/refreshVersions/blob/dea553263ed5a0a2bad38e2888b9db479b687837/CONTRIBUTING.md

Feel free to start filling the contributing docs taking inspiration from the draft linked just above, and this great docs by LeakCanary: https://square.github.io/leakcanary/how_to_help/ I'll review updates to this PR starting today after I sleep enough hours.

@LouisCAD
Copy link
Member

Here's another question: What do you plan to put in "Common errors"?

@jmfayard
Copy link
Member Author

Thanks for your improvements!

Didn't know about TK

Will think about the contributing guide.

We need to talk about migrations.

Common erros

Will replace it with FAQ

Verbs in titles should be direct (e.g. “Create a JavaScript Library and Publish it to NPM” vs. “Creating a JavaScript Library and Publishing it to NPM”). Leave the “ing” off, please.

https://medium.com/better-programming/better-programming-styleguide-suggestions-eada98e35150
@jmfayard
Copy link
Member Author

Looks good to me.
The contributing guide needs work but I propose to do it in a separate pull-request

docs/setup.md Outdated Show resolved Hide resolved
@jmfayard
Copy link
Member Author

jmfayard commented Oct 18, 2020

TODO afer call

  • Overview: Add an example with Ktor where there is AndroidX to have a server-side example
  • We saw this made developers to update the dependencies less and less often, effectively leading to legacy accumulation (a form of technical debt), or even projects abandon.
  • Slow badge: use {{version.refreshVersions}} instead of parsing maven matadata
  • Use triple backsticks for things like ./gradlew wrapper --gradle-version 6.7 to have copy/paste
  • Ensure Gradle is up to date

@LouisCAD LouisCAD self-requested a review October 18, 2020 21:51
Copy link
Member

@LouisCAD LouisCAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I think the website is really good now!

We'll address the contributing guide later.

Merging this.

@LouisCAD LouisCAD merged commit 849f228 into master Oct 18, 2020
@LouisCAD LouisCAD deleted the mkdocs branch October 18, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants