Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version alignement issue #705

Open
1 task done
MaxMichel2 opened this issue Sep 27, 2023 · 10 comments · May be fixed by #724
Open
1 task done

Version alignement issue #705

MaxMichel2 opened this issue Sep 27, 2023 · 10 comments · May be fixed by #724

Comments

@MaxMichel2
Copy link
Contributor

🐛 Describe the bug

The alignement of the versions in the version catalog is incorrect

⚠️ Current behavior

All available versions are misaligned with the currently defined one by one space, see image below

image

✅ Expected behavior

The available versions should be aligned with the currently defined version instead

💣 Steps to reproduce

Just implement refreshVersions in a project

📱 Tech info

@LouisCAD
Copy link
Member

Do you use a custom font?
Which OS are you on?

@MaxMichel2
Copy link
Contributor Author

Currently I am on Windows and I use the Inter font with the new UI (which could be the culprit)

I'll admit I didn't think about blaming the font at first considering the behaviour is correct in the versions.properties file 🤔

One thing I noticed is the appearance of the arrow in the comment which doesn't appear in the versions.properties so that could be a fix

@LouisCAD
Copy link
Member

The problem is that the width of the arrow changes from one font to the other, and I don't see how we would detect the font is different. Do you have the same problem when using the default font?

@MaxMichel2
Copy link
Contributor Author

I'll check the behaviour with the default font but this might be the issue simply (I apologise if that's the case)

An a side note, why use arrows in the versions catalog and not the versions.properties file ? Just out of curiosity 😁

@LouisCAD
Copy link
Member

Historical reasons, and we have the version. prefix in versions.properties, which gives more room to the word available without messing alignment for short keys.

@GeorgEchterling
Copy link

GeorgEchterling commented Oct 4, 2023

The arrow is also only one character wide in IntelliJ IDEA: (Using its default font "JetBrains Mono".)
image

It's worse in VS Code with "Droid Sans Mono", since it no longer matches the grid:
image

@LouisCAD
Copy link
Member

LouisCAD commented Oct 4, 2023

I also have the default font, and I get 1.8-ish character width FYI, like in VS Code, which keeps the alignement good enough for keyboard @GeorgEchterling.

@LouisCAD
Copy link
Member

LouisCAD commented Oct 4, 2023

Which OS @GeorgEchterling?

@GeorgEchterling
Copy link

GeorgEchterling commented Oct 4, 2023

@LouisCAD Fedora Linux 38 (GNOME, Wayland)

I think IntelliJ IDEA automatically scales down wide characters, since changing the font to Droid Sans Mono doesn't increase the character's width. Or maybe both fonts just don't contain the arrow and the two apps use different fallback fonts. I don't know how to test that.

@MaxMichel2 MaxMichel2 linked a pull request Aug 28, 2024 that will close this issue
@MaxMichel2
Copy link
Contributor Author

@GeorgEchterling This issue is now fixed in PR #724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants