Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using versionFor in build.gradle.kts for a key in version.properties still adds unused comment #677

Open
1 task done
podollb opened this issue Mar 2, 2023 · 3 comments
Assignees

Comments

@podollb
Copy link

podollb commented Mar 2, 2023

🐛 Describe the bug

The refreshVersions gradle task adds ## unused comment above keys that are explicitly used via the versionFor notiation.

⚠️ Current behavior

I didn't expect that the ## unused comment would appear above that key/value in the version.properties file.

✅ Expected behavior

I think refreshVersions should detect the use of that key (in the versionFor) and not add the ## unsed comment above it in version.properties.

💣 Steps to reproduce

Add a key/value to version.properties like version.foo=1.2.3
Use that in your build.gradle.kts file via the versionFor("version.foo") notation
Run ./gradlew refreshVersions

The ## unused comment appears above that key/value in the version.properties file.

📱 Tech info

@LouisCAD LouisCAD self-assigned this Mar 8, 2023
@podollb
Copy link
Author

podollb commented Jul 10, 2024

Any updates on this?

@LouisCAD
Copy link
Member

Try putting a dependency notation instead

@podollb
Copy link
Author

podollb commented Jul 12, 2024

I'm not sure I understand, instead of versionFor("version.foo") what should I use in my logic in my gradle build file? I'm using the value in some conditional logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants