Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Play Services dependencies #493

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Add Play Services dependencies #493

merged 3 commits into from
Jan 24, 2022

Conversation

imashnake0
Copy link
Contributor

@imashnake0 imashnake0 commented Jan 19, 2022 •
edited
Loading

🚀 Description

Added missing Play Services dependencies.

📄 Motivation and Context

Resolves #486.

🧪 How Has This Been Tested?

Ran ./gradlew check and tested on sample-android.

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

@imashnake0
Added dependencies for Phones and Tablets
4f8132b 
Excluding ads (first four).
@imashnake0
Fixed typo
6a3f1a2 
Fixed Minor typo.
@imashnake0
Ran ./gradlew check
520e484 
Tested on sample-android.
@imashnake0 imashnake0 marked this pull request as draft January 19, 2022 10:43
@imashnake0
Copy link
Contributor Author

imashnake0 commented Jan 19, 2022 •
edited
Loading

Missing dependencies:

Phones and Tablets

  • com.google.android.gms:play-services-ads:20.5.0
  • com.google.android.gms:play-services-ads-identifier:18.0.1
  • com.google.android.gms:play-services-ads-lite:20.5.0
  • com.google.android.gms:play-services-afs-native:19.0.3
  • com.google.android.gms:play-services-analytics:18.0.1
  • com.google.android.gms:play-services-appset:16.0.2
  • com.google.android.gms:play-services-auth:20.0.1
  • com.google.android.gms:play-services-auth-api-phone:18.0.1
  • com.google.android.gms:play-services-auth-blockstore:16.1.0
  • com.google.android.gms:play-services-awareness:19.0.1
  • com.google.android.gms:play-services-base:18.0.1
  • com.google.android.gms:play-services-basement:18.0.0
  • com.google.android.gms:play-services-cast:21.0.1
  • com.google.android.gms:play-services-cast-framework:21.0.1
  • com.google.android.gms:play-services-cronet:18.0.1
  • com.google.android.gms:play-services-fido:19.0.0-beta
  • com.google.android.gms:play-services-fitness:21.0.1
  • com.google.android.gms:play-services-games:22.0.1
  • com.google.android.gms:play-services-instantapps:18.0.1
  • com.google.android.gms:play-services-location:19.0.1
  • com.google.android.gms:play-services-maps:18.0.2
  • com.google.android.gms:play-services-mlkit-barcode-scanning:17.0.0
  • com.google.android.gms:play-services-mlkit-face-detection:16.2.1
  • com.google.android.gms:play-services-mlkit-image-labeling:16.0.6
  • com.google.android.gms:play-services-mlkit-image-labeling-custom:16.0.0-beta2
  • com.google.android.gms:play-services-mlkit-language-id:16.0.0-beta2
  • com.google.android.gms:play-services-mlkit-text-recognition:17.0.1
  • com.google.android.gms:play-services-nearby:18.0.2
  • com.google.android.gms:play-services-oss-licenses:17.0.0
  • com.google.android.gms:play-services-password-complexity:18.0.1
  • com.google.android.gms:play-services-pay:16.0.3
  • com.google.android.gms:play-services-recaptcha:17.0.1
  • com.google.android.gms:play-services-safetynet:18.0.1
  • com.google.android.gms:play-services-tagmanager:18.0.1
  • com.google.android.gms:play-services-tasks:18.0.1
  • com.google.android.gms:play-services-vision:20.1.3
  • com.google.android.gms:play-services-wallet:19.0.1
  • com.google.android.gms:play-services-wearable:17.1.0
  • com.google.android.gms:oss-licenses-plugin:0.10.4
  • com.google.android.gms:strict-version-matcher-plugin:1.2.2

Android TV

  • com.google.android.gms:play-services-ads-identifier:18.0.1
  • com.google.android.gms:play-services-analytics:18.0.1
  • com.google.android.gms:play-services-appset:16.0.2
  • com.google.android.gms:play-services-auth:20.0.1
  • com.google.android.gms:play-services-base:18.0.1
  • com.google.android.gms:play-services-basement:18.0.0
  • com.google.android.gms:play-services-cast-tv:19.0.1
  • com.google.android.gms:play-services-cronet:18.0.1
  • com.google.android.gms:play-services-fido:19.0.0-beta
  • com.google.android.gms:play-services-games:22.0.1
  • com.google.android.gms:play-services-instantapps:18.0.1
  • com.google.android.gms:play-services-location:19.0.1
  • com.google.android.gms:play-services-maps:18.0.2
  • com.google.android.gms:play-services-nearby:18.0.2
  • com.google.android.gms:play-services-oss-licenses:17.0.0
  • com.google.android.gms:play-services-recaptcha:17.0.1
  • com.google.android.gms:play-services-safetynet:18.0.1
  • com.google.android.gms:play-services-tagmanager:18.0.1
  • com.google.android.gms:play-services-tasks:18.0.1

Auto

  • com.google.android.gms:play-services-analytics:18.0.1
  • com.google.android.gms:play-services-auth:20.0.1
  • com.google.android.gms:play-services-awareness:19.0.1
  • com.google.android.gms:play-services-base:18.0.1
  • com.google.android.gms:play-services-basement:18.0.0
  • com.google.android.gms:play-services-cronet:18.0.1
  • com.google.android.gms:play-services-fido:19.0.0-beta
  • com.google.android.gms:play-services-location:19.0.1
  • com.google.android.gms:play-services-maps:18.0.2
  • com.google.android.gms:play-services-nearby:18.0.2
  • com.google.android.gms:play-services-oss-licenses:17.0.0
  • com.google.android.gms:play-services-safetynet:18.0.1
  • com.google.android.gms:play-services-tasks:18.0.1
  • com.google.android.gms:play-services-wallet:19.0.1

Android Go

  • com.google.android.gms:play-services-analytics:18.0.1
  • com.google.android.gms:play-services-auth:20.0.1
  • com.google.android.gms:play-services-auth-api-phone:18.0.1
  • com.google.android.gms:play-services-auth-blockstore:16.1.0
  • com.google.android.gms:play-services-awareness:19.0.1
  • com.google.android.gms:play-services-base:18.0.1
  • com.google.android.gms:play-services-basement:18.0.0
  • com.google.android.gms:play-services-cast:21.0.1
  • com.google.android.gms:play-services-cast-framework:21.0.1
  • com.google.android.gms:play-services-cronet:18.0.1
  • com.google.android.gms:play-services-fido:19.0.0-beta
  • com.google.android.gms:play-services-fitness:21.0.1
  • com.google.android.gms:play-services-games:22.0.1
  • com.google.android.gms:play-services-instantapps:18.0.1
  • com.google.android.gms:play-services-location:19.0.1
  • com.google.android.gms:play-services-maps:18.0.2
  • com.google.android.gms:play-services-mlkit-barcode-scanning:17.0.0
  • com.google.android.gms:play-services-mlkit-face-detection:16.2.1
  • com.google.android.gms:play-services-mlkit-image-labeling:16.0.6
  • com.google.android.gms:play-services-mlkit-image-labeling-custom:16.0.0-beta2
  • com.google.android.gms:play-services-mlkit-language-id:16.0.0-beta2
  • com.google.android.gms:play-services-mlkit-text-recognition:17.0.1
  • com.google.android.gms:play-services-nearby:18.0.2
  • com.google.android.gms:play-services-oss-licenses:17.0.0
  • com.google.android.gms:play-services-password-complexity:18.0.1
  • com.google.android.gms:play-services-pay:16.0.3
  • com.google.android.gms:play-services-recaptcha:17.0.1
  • com.google.android.gms:play-services-safetynet:18.0.1
  • com.google.android.gms:play-services-tagmanager:18.0.1
  • com.google.android.gms:play-services-tasks:18.0.1
  • com.google.android.gms:play-services-vision:20.1.3
  • com.google.android.gms:play-services-wallet:19.0.1

Chrome OS

  • com.google.android.gms:play-services-ads-identifier:18.0.1
  • com.google.android.gms:play-services-afs-native:19.0.3
  • com.google.android.gms:play-services-analytics:18.0.1
  • com.google.android.gms:play-services-appset:16.0.2
  • com.google.android.gms:play-services-auth:20.0.1
  • com.google.android.gms:play-services-auth-blockstore:16.1.0
  • com.google.android.gms:play-services-awareness:19.0.1
  • com.google.android.gms:play-services-base:18.0.1
  • com.google.android.gms:play-services-basement:18.0.0
  • com.google.android.gms:play-services-cast:21.0.1
  • com.google.android.gms:play-services-cast-framework:21.0.1
  • com.google.android.gms:play-services-cronet:18.0.1
  • com.google.android.gms:play-services-fido:19.0.0-beta
  • com.google.android.gms:play-services-fitness:21.0.1
  • com.google.android.gms:play-services-games:22.0.1
  • com.google.android.gms:play-services-instantapps:18.0.1
  • com.google.android.gms:play-services-location:19.0.1
  • com.google.android.gms:play-services-maps:18.0.2
  • com.google.android.gms:play-services-mlkit-barcode-scanning:17.0.0
  • com.google.android.gms:play-services-mlkit-face-detection:16.2.1
  • com.google.android.gms:play-services-mlkit-image-labeling:16.0.6
  • com.google.android.gms:play-services-mlkit-image-labeling-custom:16.0.0-beta2
  • com.google.android.gms:play-services-mlkit-language-id:16.0.0-beta2
  • com.google.android.gms:play-services-mlkit-text-recognition:17.0.1
  • com.google.android.gms:play-services-oss-licenses:17.0.0
  • com.google.android.gms:play-services-password-complexity:18.0.1
  • com.google.android.gms:play-services-pay:16.0.3
  • com.google.android.gms:play-services-recaptcha:17.0.1
  • com.google.android.gms:play-services-safetynet:18.0.1
  • com.google.android.gms:play-services-tagmanager:18.0.1
  • com.google.android.gms:play-services-tasks:18.0.1
  • com.google.android.gms:play-services-vision:20.1.3
  • com.google.android.gms:play-services-wallet:19.0.1

@imashnake0 imashnake0 marked this pull request as ready for review January 19, 2022 11:55
@imashnake0 imashnake0 changed the title Play services Add Play Services dependencies Jan 19, 2022
@LouisCAD
Copy link
Member

Thanks for the high quality PR!

Learned the existence of some Play Services APIs in the way.

@LouisCAD LouisCAD merged commit aa54787 into Splitties:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing Google Play Services dependency notations
2 participants
@imashnake0 @LouisCAD