Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unspecified yet version of Gradle plugins #476

Open
1 of 3 tasks
LouisCAD opened this issue Dec 22, 2021 · 1 comment
Open
1 of 3 tasks

Support unspecified yet version of Gradle plugins #476

LouisCAD opened this issue Dec 22, 2021 · 1 comment
Assignees
Milestone

Comments

@LouisCAD
Copy link
Member

LouisCAD commented Dec 22, 2021

⚠️ Is your feature request related to a problem? Please describe

The version placeholder is not supported for the plugins DSL, which requires the users to know the version and put it manually in the version.properties file, respecting the expected plugin.id.of.the.plugin=x.x.x syntax.

This is not very intuitive, and we know a lot of folks with skip reading the relevant part in the documentation.

💡 Describe the solution you'd like

I believe there are 3 things we can do to help:

  1. Detect when an underscore is set as the version of the Gradle plugin, and fail the build with a helpful error message.
  2. Before failing the build when an underscore is detected as a version of a Gradle plugin, fill the versions.properties file as done for non plugin dependencies, so the only action remaining is to remove the version placeholder (and maybe use a non stable release), which can also be done automatically if the version placeholder is inline (i.e. in a gradle script, precompiled or not, as opposed to being in a version catalog or in a custom plugin)
  3. Support non specifying the version when adding the version key, allowing filling something like: plugin.id.of.the.plugin=?, where refreshVersions would straightaway fill the latest most stable version and available less stable versions, and use it immediately, avoiding a failing Gradle sync and the price of the "configuration" time.

🤚 Do you want to develop this feature yourself?

  • Yes
  • Maybe (probably)
  • No
@LouisCAD LouisCAD added this to the v1.0.0 milestone Dec 22, 2021
@imashnake0
Copy link
Contributor

Working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants