Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to automate migration for added version key rules and added dependency notations #259

Closed
LouisCAD opened this issue Oct 11, 2020 · 1 comment
Assignees

Comments

@LouisCAD
Copy link
Member

Ideally, the tests that already make sure we don't remove any dependency notation should also fail on additions, after generating migration resources to be picked up by migration code, and the tests would pass again after the migration resources add edited.

A manual edit would also be required to ensure just running the tests twice doesn't succeeds.

I think a pair-programming session with you @jmfayard would be great to tackle this issue with a great solution that helps us move faster and safer regarding bundling dependency notations.

Finally, we could also handle dependency notations removals and renames to be able to remove support for some of them if needed without breaking users badly.

@jmfayard
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants