-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Renovate Bot #207
Comments
It's complicated and would certainly require work on Renovate bot's end. I'll keep this open, but this is low priority as I'm focused on version 1.0 (and on vacation). |
If someone wants to work on this from the Renoavte Bot side, I can provide information on how that would work |
I'd be curious what's needed for this to work! |
I had a look at what Renovate Bot here galacticcouncil/substrate-api-explorer#114 and here mulesoft/mule-migration-assistant#406 It seems to me that it should be quite easy for the bot to
That's the whole point of it by the way, this file is machine readable and writable. Given a it could then reformat it in the issue like this:
And in the pull request it would just do ## versions.properties
- version.kotlinx.coroutines=1.3.1
+ version.kotlinx.coroutines=1.3.7 Now ideally you would have a CI setup so that you run the unit tests for example to checck whether you have a compability problem with the new version. (The only question would be how you filter the multiple options to just one) |
Discover thanks to Twitter how renovabot currently works |
AFAIK the approach here would be to add |
I came here to file this bug upon seeing https://github.com/renovatebot/renovate/pull/16684/files which adds support for kts files. Does this still seem feasible? |
@yschimke Kotlin scripts support in dependabot isn't related to refreshVersions. Are you using refreshVersion already? If yes there is no need to use dependabot. |
@jmfayard , I believe the PR was just a sample integration.
I'm afraid, that is the other way around. So it would make total sense to add something like PR 16684 above, except it should consume and update |
If somoeone wants to work on dependabot for that, I'm totally fine. It seems like they are doing manual parsing? That's a bit sad. They would never fully support Gradle this way, it's turing complete. If they use Gradle there is nothing special they need to do query the list of dependencies and versions managed by refreshVersions. |
Yep, wasn't linking to that PR as a solution, more as a recent example showing they take contributions, and the complexity of this sort of support. |
As I said, the complexity depend on whether they do manual parsing or can call Gradle. |
I do not think parsing |
With manual parsing, dependabot can't know that the key |
nit: Is dependabot a generic term? I thought it and renovate were different products? Hopefully the solution could be adapted for both. |
Oh, I missed aliases. |
Also FYI @yschimke they don't support versions catalogs |
OK. Heres a renovate PR for it square/okhttp#7386 |
Ah the issue is resolved then. |
definitely not a generic term @yschimke. Dependabot and Renovate are two competitors (Dependabot doesn't indeed support version catalog Gradle feature). also, did you link to the wrong PR in your last comment? I don't understand the relation with the current discussion (this is just an example of a Renovate PR) and I don't understand why @jmfayard comes to the conclusion the issue is resolved 🤔 |
Yep, I confused everyone with a PR showing support for kts. Sorry for confusing this message.
The previous links to examples were from 2020, so thought a fresh sample of an integration could help. I'll leave now... |
Renovate Bot is only supporting updating version numbers in
gradle.properties
. Probably it also doesn't understand the "_
"-placeholder.Is there a way to get Renovate Bot working while still using your Plugin with all it's advantages? I would love to have the feature of automatic PR creation for Dependency Updates but as we are using Bitbucket the number of possible applications to do this is quite low :(
The text was updated successfully, but these errors were encountered: