Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is buildSrcVersions gone? #119

Closed
DanySK opened this issue Oct 29, 2019 · 7 comments
Closed

is buildSrcVersions gone? #119

DanySK opened this issue Oct 29, 2019 · 7 comments
Assignees

Comments

@DanySK
Copy link
Contributor

DanySK commented Oct 29, 2019

I tried to switch to the new naming system:

plugins {
    id("de.fayard.refreshVersions") version "0.7.0"
}

If I use version 0.7.0, I can run the buildSrcVersions task flawlessly. It also proposes an upgrade to 0.8.1. If do so, however, buildSrcVersions is no longer available as task.

  • Are de.fayard.buildSrcVersions and de.fayard.refreshVersions the same plugin, as the guide seems to suggest?
  • Am I supposed to stay with de.fayard.buildSrcVersions if I want to keep on using the buildSrcVersions task?
  • Has the task got renamed? Has it been dropped completely?
@jmfayard
Copy link
Member

Hello @DanySK
my plan for 1.0 is to focus on gradle refreshVersions

It means a few different things:

  • id("de.fayard.refreshVersions") version "0.8.1" } and better to not have the buildSrcVersions task anymore
  • Declaring the versions numbers not in code but in a proper tooling-friendly file format versions.properties is better than using buildSrc/src/main/Versions.kt
  • Having a file buildSrc/src/main/Libs.kt to use auto-complete is however a good idea. But if you think about it, the buildSrc is a private Gradle plugin. Why not a public Gradle plugin that contains the magic dependencies strings that are commonly used. I am working with @LouisCAD on this
  • Things are evolving fast and I suggest to stay for now id("de.fayard.buildSrcVersions") version "0.7.0" } if you are using the task buildSrcVersions

The README needs to be updated to reflect this but I am on vacation right now

@DanySK
Copy link
Contributor Author

DanySK commented Oct 30, 2019

Hi @jmfayard
thanks for the answer. I was confused by the readme, which said the plugins were supposed to be the same. I'll stick to buildSrc for now, looking forward to the new infrastructure.

If my understanding is correct, there will be a Gradle plugin for generating/accessing compile-time shorthands for libraries (the great work Libs.kt is doing now), while versions will be dealt with using refreshVersions.
Is that correct?

Do you foresee major changes to the format of the file produced by refreshVersions?

@jmfayard
Copy link
Member

@DanySK you are correct.
The file will be a Java properties file called versions.properties
The major change planned will be only if Gradle itself introduces its own file format for declaring properties, as I learned they would like to do. Then of course we will switch to that

@martinbonnin
Copy link
Contributor

I just got bit by that as well and started updating the README (#133) before realising it might require more than a few fixes. @jmfayard should I try to update the README to make it closer to the latest release ?

@martinbonnin
Copy link
Contributor

Should this issue be closed ?

@LouisCAD LouisCAD self-assigned this Mar 11, 2020
@LouisCAD
Copy link
Member

I'm leaving it closed as we need to document refreshVersions better and keep an overview document on what changed and why, for history.

@jmfayard
Copy link
Member

Duplicate on #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants