Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Desktop notifications not showing user icon #145

Open
Mason-17 opened this issue Nov 6, 2023 · 8 comments
Open

[Bug] Desktop notifications not showing user icon #145

Mason-17 opened this issue Nov 6, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@Mason-17
Copy link

Mason-17 commented Nov 6, 2023

Describe the bug
There are no notifications (despite them being on). Discord status is also set to active. There is also no change in the icon on the bottom of the screen.

To Reproduce
Steps to reproduce the behavior:

  1. use Dorion
  2. get notification
  3. only hear sound, but don't get actual notification

Expected behavior
Desktop notifications and icon change.

Screenshots
If applicable, add screenshots to help explain your problem.

System Info (please complete the following information):

  • OS: Windows 11
  • Version: v2.1.0
  • Any other relevant info:

Additional context
Add any other context about the problem here.

@Mason-17 Mason-17 added the bug Something isn't working label Nov 6, 2023
@SpikeHD SpikeHD changed the title No Desktop Notifications [Bug] [Bug] No Desktop Notifications Nov 6, 2023
@SpikeHD
Copy link
Owner

SpikeHD commented Nov 7, 2023

I think(?) this is a symptom of plugins not properly starting (#143), unless you know for sure things like Dorion Settings were showing during the session you noticed notifications show up. Next time you notice them not showing up, check DevTools. You might have something along the lines of a "permission denied" error which I believe you can fix by clearing web data (middle button in Performance & Extras)

@Mason-17
Copy link
Author

Mason-17 commented Nov 7, 2023

I think(?) this is a symptom of plugins not properly starting (#143), unless you know for sure things like Dorion Settings were showing during the session you noticed notifications show up. Next time you notice them not showing up, check DevTools. You might have something along the lines of a "permission denied" error which I believe you can fix by clearing web data (middle button in Performance & Extras)

Thing is though, the notifications haven't worked. I haven't used Dorion for about a month, but I remember notifications working then.

@SpikeHD
Copy link
Owner

SpikeHD commented Nov 7, 2023

Back then I was using a Vencord patch, but since I've nixed Vencord in favor of Shelter, that patch has been replaced with slightly different functionality. I'll just move the notifications to the backend fully since that should also fix a problem someone was having with Windows 7

@Mason-17
Copy link
Author

Mason-17 commented Nov 7, 2023

Back then I was using a Vencord patch, but since I've nixed Vencord in favor of Shelter, that patch has been replaced with slightly different functionality. I'll just move the notifications to the backend fully since that should also fix a problem someone was having with Windows 7

Awesome, can't wait to see it!

@SpikeHD
Copy link
Owner

SpikeHD commented Nov 8, 2023

I've moved notifications to be (almost) entirely handled by the backend, so no more permission screwery. Combined with the more stable plugins stuff, this issue should be fixed when the next release hits, feel free to reopen if it doesn't fix it

@SpikeHD SpikeHD closed this as completed Nov 8, 2023
@Mason-17
Copy link
Author

Reopening, since the taskbar icon doesn't show a message as incoming. However, there is now a desktop notification when that setting is enabled. Also, no pfp icons are in the desktop notification.

@SpikeHD
Copy link
Owner

SpikeHD commented Nov 10, 2023

Taskbar icon is a separate issue (#27) already, but the missing icon should be something I can solve

@SpikeHD SpikeHD reopened this Nov 10, 2023
@Mason-17
Copy link
Author

Taskbar icon is a separate issue (#27) already, but the missing icon should be something I can solve

Didn't realize it was already an issue. Thanks.

@SpikeHD SpikeHD changed the title [Bug] No Desktop Notifications [Bug] Desktop notifications not showing user icon Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants