-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looking for additional maintainers #350
Comments
I would be happy to help out. Not sure how much code contributions I could do, but at minimum, I'd like to help organize a V1 release project (like https://github.com/pay-rails/pay/projects/1) to understand the scope and what it will take to get to a V1. It'd be nice to know what is in scope and out of scope. Let me know if you're interested. :) |
Hi @joshbuker, I'd be happy to help review and merge a few PRs! |
@joshbuker I can help with sorcery support for new Rails and Ruby, bug fixes, etc. |
Thanks for the Mastodon ping, @dylhack; I haven't been getting GitHub notifications. @jonmchan, @Spone, @willnet, I think the best course of action would be to get the v1 rework finished or to create a migration guide for users to one of the other auth gems. Personally, I would prefer to see v1 completed, but I would need help doing that. Both project management to understand what remains to be done before release and additional folks to help with the test suite would be greatly appreciated. Because v1 will eliminate entire classes of issues (e.g., switching to Omniauth will eliminate the need to maintain provider implementations for OAuth), I don't think spending time trying to get v0 up-to-date with the latest Rails would make sense. |
@joshbuker do you have a list of items to start with? If you have that and give me access to start a project for this repo, I can start populating a board for it. Might be good to have a kickoff meeting with everyone interested in being involved. We could see what resources we have and make rough estimates on a v1 release timeline based off of everyone's availability. We could have bi-weekly or monthly check-ins to make sure the v1 release stays on schedule. With rails 7 out for a good amount of time now, I think support for that is necessary to keep this gem relevant. I would definitely be interested in seeing this gem stay current. :) |
@jonmchan Honestly, if we just took each file/test from the v0 test suite and made that into a card/task, that would probably be sufficient to push things to the finish line. Do some proper TDD. Check-ins would be helpful for accountability on my end, and help with motivation. Could also use it as an opportunity for new folks to ask questions and help too. Bi-weekly would work on my end. I've invited you to the GitHub org. If that doesn't give you access to the project management, let me know and I can find wherever that permission is hidden. |
Do you have a discord or some other real time chat? Might be useful to starting a community and some real time communication on project planning. Would love to put a general word out to all the different ruby groups to see if we can solicit support for the project. At 4.9M downloads, this gem has a lot of use and I am sure there are at least some people who use this who would be willing to donate time to keep the project alive and improve it. I will take a look at the files and put a few things down. Will let you know if I can access the project management section or not when I get a chance to try it. |
Is there a branch for v1 release yet? I think it would be good for us to see what is already done or where the state of things are in understanding how far we need to go. From the sounds of it, you have some code already written for v1? |
@jonmchan it's a separate repo: https://github.com/Sorcery/sorcery-rework |
I completed the spec/active_record folder, can you please check https://github.com/orgs/Sorcery/projects/3/views/1. Please verify this is the format that you want or if there is anything I need to tweak or change before I do the rests of the specs in the other folders. Thank you! |
@joshbuker Thank you for inviting me to the Sorcery organization. I might not have a lot of time to spare, but I plan to review Issues and PRs as much as I can. |
@joshbuker ping? I would like to complete the setup of the project and start building a release timeline - your input would be helpful. |
I just turned email notifications back on, so I should hopefully see comments sooner now. @jonmchan That format looks good! Could you use the project I created with some of my remaining tasks so that we can deduplicate them? https://github.com/orgs/Sorcery/projects/1/views/1 |
Unfortunately, I have not been able to dedicate much time to pushing Sorcery forward, and things like Rails 7 support, version 1 release, switching to Omniauth for SSO, Passkey support, etc, have fallen behind schedule by a factor of years.
I still plan on pushing these efforts forward, but to accelerate the process to a reasonable timeframe, it would be good to pull in additional maintainers for the project.
If you are interested in helping, please let me know via this issue or by working on issues/pull requests marked "help wanted."
The text was updated successfully, but these errors were encountered: