Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_find_library resolves path in a uncommon order #176

Closed
jeff-dh opened this issue May 23, 2021 · 0 comments
Closed

_find_library resolves path in a uncommon order #176

jeff-dh opened this issue May 23, 2021 · 0 comments

Comments

@jeff-dh
Copy link
Contributor

jeff-dh commented May 23, 2021

def _find_library(library_name: PathStr) -> Path:
            result = Path(library_name)
            if not result.is_absolute():
                paths = _openscad_library_paths()
                for p in paths:
                    f = p / result
                    # print(f'Checking {f} -> {f.exists()}')
                    if f.exists():
                        result = f
            return result

This means a file found in paths[2] overwrites a file in paths[0] and since openscad_library_paths returns [".", os.env_paths, "platform_path"] if I understand it correctly, a file in the "platform_path" (.local/share/openscad/libraries/) would overwrite a local file (./). I think this is not the way resolving filenames are usually working.

I think the line result = f should be return f.
(cf resolve_scad_filename from 1a1d97c)

Furthermore what about system include path? At least on my system MCAD is also installed in /usr/share/openscad/libraries/MCAD I guess this should be added to _openscad_library_paths, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant