Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request Arc Overhang #902

Closed
TechDude23 opened this issue Apr 30, 2023 · 18 comments
Closed

Feature request Arc Overhang #902

TechDude23 opened this issue Apr 30, 2023 · 18 comments
Labels

Comments

@TechDude23
Copy link

Can this be added to the Orca Slicer Arc Overhang

@scottmudge
Copy link
Contributor

scottmudge commented May 9, 2023

Working on implementing this on my fork: https://github.com/scottmudge/OrcaSlicer/tree/feature_arc-overhangs

No promises yet -- there are significant differences between OrcaSlicer and SuperPleccer, which may require some debugging/modifications.

If I get something working, I'll submit a PR

@TechDude23
Copy link
Author

Thank you 🥇

@GuzziRaz
Copy link
Contributor

Dupe of #409

Copy link

GitHub bot: this issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added stale and removed stale labels Nov 29, 2023
@kostecky
Copy link

Any luck on this?

@starschild86
Copy link

Would also be very interested in knowing when this will be available

@Rickthebig
Copy link

Checking this topic almost every day...
Arc overhang urgently needed!

@pagdot
Copy link
Contributor

pagdot commented Mar 20, 2024

@Rickthebig
You can use https://github.com/Kelsch/arc-overhang-orcaslicer-integration in the meantime. It is a PoC implementation based on the on the prusa slicer integration which is based on the original script. There are both forks of SuperSlicer (forked of PrusaSlicer) and OrcaSlicer, but development of both seems to have stopped months ago. I have already found a major issue with the current implementation(s) with it starting the arcs on a not supported edge. IMO it is a nice PoC and I'd like to see it integrated in slicers in the future, but the algorithm isn't there yet

@Rickthebig
Copy link

Rickthebig commented Mar 20, 2024

@Rickthebig You can use https://github.com/Kelsch/arc-overhang-orcaslicer-integration in the meantime. It is a PoC implementation based on the on the prusa slicer integration which is based on the original script. There are both forks of SuperSlicer (forked of PrusaSlicer) and OrcaSlicer, but development of both seems to have stopped months ago. I have already found a major issue with the current implementation(s) with it starting the arcs on a not supported edge. IMO it is a nice PoC and I'd like to see it integrated in slicers in the future, but the algorithm isn't there yet

Thanks, hope dies the last.
I tried to use it as a postprocessor but as I am using Windows 10 right now, and some libraries are needed that are not available for Windows out-of-the-box, python 3.9 throws an error:

Traceback (most recent call last):
File "softfever_slicer_post_processing_script.py", line 41, in
from shapely import Point, Polygon, LineString, GeometryCollection, MultiLineString, MultiPolygon
ModuleNotFoundError: No module named 'shapely'

Quote from https://shapely.readthedocs.io/en/latest/installation.html:
"We do not have a recipe for Windows platforms."
So currently the postprocessor seems to be limited to Linux users, although you are giving instructions for using it under Windows.
Correct me If I am wrong.

@Rickthebig
Copy link

Wait - I did find a shapely library for Windows:
https://pypi.org/project/shapely/#files
I will let you know the outcome.

@Rickthebig
Copy link

Unfortunately the script cannot be executed:
from shapely import Point, Polygon, LineString, GeometryCollection, MultiLineString, MultiPolygon
ModuleNotFoundError: No module named 'shapely'

The library was successfully installed:

pip install shapely
Defaulting to user installation because normal site-packages is not writeable
Collecting shapely
Downloading shapely-2.0.3-cp312-cp312-win_amd64.whl.metadata (7.2 kB)
Collecting numpy<2,>=1.14 (from shapely)
Downloading numpy-1.26.4-cp312-cp312-win_amd64.whl.metadata (61 kB)
---------------------------------------- 61.0/61.0 kB 461.8 kB/s eta 0:00:00
Downloading shapely-2.0.3-cp312-cp312-win_amd64.whl (1.4 MB)
---------------------------------------- 1.4/1.4 MB 4.8 MB/s eta 0:00:00
Downloading numpy-1.26.4-cp312-cp312-win_amd64.whl (15.5 MB)
---------------------------------------- 15.5/15.5 MB 5.9 MB/s eta 0:00:00
Installing collected packages: numpy, shapely
WARNING: The script f2py.exe is installed in 'C:\Users...\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed numpy-1.26.4 shapely-2.0.3

This is a common error when python is used by a layman like me...

@Rickthebig
Copy link

The script won't run:
python3.12.exe softfever_slicer_post_processing_script.py
Traceback (most recent call last):
File "...\softfever_slicer_post_processing_script.py", line 628, in
class BridgeInfill():
File "...\softfever_slicer_post_processing_script.py", line 629, in BridgeInfill
def init(self,pts=[],id=random.randint(1,1e10)) -> None:
^^^^^^^^^^^^^^^^^^^^^^
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.12_3.12.752.0_x64__qbz5n2kfra8p0\Lib\random.py", line 336, in randint
return self.randrange(a, b+1)
^^^^^^^^^^^^^^^^^^^^^^
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.12_3.12.752.0_x64__qbz5n2kfra8p0\Lib\random.py", line 312, in randrange
istop = _index(stop)
^^^^^^^^^^^^
TypeError: 'float' object cannot be interpreted as an integer

Although I installed python 3.9, the libraries are found only when using python 3.12

I will have to run the script using python 3.19 and see.

@Rickthebig
Copy link

I got the versions straight, now processing the script using python 3.9 I get:
File "softfever_slicer_post_processing_script.py", line 325, in
def getPtfromCmd(line:str)->Point | None:
TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'

Perhaps I will have to dive into python to at least correct the syntax errors!

@scrampker
Copy link

@Rickthebig

Use WSL Ubuntu if you're wanting to run Python in a linux environment.

Copy link

github-actions bot commented Jul 2, 2024

Orca bot: this issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Jul 2, 2024
Copy link

Orca bot: This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
@tim-gromeyer
Copy link

Any news?

@federicoparra
Copy link

Working on implementing this on my fork: https://github.com/scottmudge/OrcaSlicer/tree/feature_arc-overhangs

No promises yet -- there are significant differences between OrcaSlicer and SuperPleccer, which may require some debugging/modifications.

If I get something working, I'll submit a PR

Hi! have you gotten to develop a working version of the algorithm in your branch? Should I compile it and try it? I use a bambu lab A1 and with it I have no luck with the post-processing script :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants