Timelapse download and delete buttons are misaligned when there are only two of them resulting in deletion of files by accident

[sneakyjoeru]

Is there an existing issue for this problem?

• I have searched the existing issues

OrcaSlicer Version

2.1.0-beta

Operating System (OS)

Linux, Windows

OS Version

windows 11, kubuntu 22.04

Additional system information

No response

Printer

Bambulab X1C

How to reproduce

Have timelapse. Try to dowload. If you press left part of the button it will delete instead. Looks like you can press to the right of a button on a blank area and it will download still

Actual results

Misaligned button, that deletes file if you're not paying attention

Expected results

Downloading of a file.

Project file & Debug log uploads

no need, as reproduced on 2 separate OS

Checklist of files to include

• Log file
• Project file

Anything else?

Please fix it - it's very annoying.

[Chewieez]

I've noticed this for the past few versions. I agree it can lead to accidental deletion if you're not paying attention.

[xoma262]

That's an issue that needs to be addressed eventually.

[g3gg0]

pushing this as this is quite annoying.

did some investigation why this is happening.

Issue: you are adding either two or three buttons and expect that the hitboxes are 33% each.
however before downloadings the third action is empty:

OrcaSlicer/src/slic3r/GUI/ImageGrid.cpp

Line 622 in 2bf5487

wxString thirdAction;

visually this results in three button sections:

however the logic uses TWO hitboxes with 50% each

there you add the "empty" (or undefined) third option that behaves weird:

OrcaSlicer/src/slic3r/GUI/ImageGrid.cpp

Line 655 in 2bf5487

texts.Add(thirdAction);

didn't check exactly, but i guess the reason for the 2 / 3 item check is there

OrcaSlicer/src/slic3r/GUI/ImageGrid.cpp

Line 277 in 2bf5487

int btn = file.IsDownload() && file.DownloadProgress() >= 0 ? 3 : 2;

if i had it set up to build locally, i'd either change ImageGrid.cpp:655 to not add the button when not downloading (favorite),
or change ImageGrid.cpp:277 to always return 3 without checking if is downloading / downloaded.

[g3gg0]

guess this is the related commit that introduced the behavior, as thirdAction.IsEmpty() was checked before that commit.
ca534b5
so @mia-0 might be the right person to ask for checking this, or @SoftFever as merger of #2218