BUG: Update slicer.util.reloadScriptedModule to remove layout item after cleanup #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
reviewed
Jun 19, 2019
Base/Python/slicer/util.py
Outdated
| # call cleanup function for the existing widget | ||
| if hasattr(slicer.modules, widgetName): | ||
| w = getattr(slicer.modules, widgetName) | ||
| w.cleanup() |
There was a problem hiding this comment.
Is cleanup called again when module is about to be unloaded?
Should we call something like this to avoid double cleanup?
slicer.app.moduleManager().disconnect('moduleAboutToBeUnloaded(QString)', w._onModuleAboutToBeUnloaded)
There was a problem hiding this comment.
Good point, the signal should indeed be disconnected.
…ter cleanup Removing the layout item after calling the cleanup function give the widget an opportunity to reference existing layout during its own cleanup.
…on exit Co-authored-by: Andras Lasso <[email protected]>
c83f391
to
1980763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.