Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Ensure tests fail if an internal error is caught #1129

Closed
wants to merge 1 commit into from
Closed

BUG: Ensure tests fail if an internal error is caught #1129

wants to merge 1 commit into from

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Apr 17, 2019

No description provided.

@jcfr jcfr requested a review from lassoan April 17, 2019 21:15
@jcfr
Copy link
Member Author

jcfr commented Apr 17, 2019

While working on updating https://github.com/QIICR/PETTumorSegmentation to support qt5 and python3, I realized that execution of self-test leading to an internal error were displaying a popup while running the test. This commit ensure the application exit with an error code when running with --testing flag.

Cc: @fedorov @pieper

@jcfr
Copy link
Member Author

jcfr commented Apr 17, 2019

Closing. Integrated in r28151

@jcfr jcfr closed this Apr 17, 2019
@jcfr jcfr deleted the testing-mode-exit-with-failure-if-internal-error branch April 17, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassoan lassoan Awaiting requested review from lassoan

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcfr