-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUGGESTION] please set config:timeout default to false #255
Comments
Hi @SegFaulty |
The problem here is that you are testing for timeout = false in the configuration, which is triggering a deprecation error even if we don't set a timeout value. IMO, this isn't backwards compatible at all, as a deprecation error is not the previous behaviour. |
in a fresh installation, with default setting we get:
Deprecated: The "timeout" configuration is deprecated and will be removed with the next major update. Set the "timeout" configuration to false and if needed use the set_timeout_limit() function in your own code. in ..vendor/rakibtg/sleekdb/src/Store.php on line 748
but if one use the default settings, there should no deprecation message.
now we have to supply:
suggested fix:
The text was updated successfully, but these errors were encountered: