Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate class com.google.android.play.core.appupdate.AppUpdateInfo found in modules jetified-app-update-2.0.1-runtime #129

Closed
danielmessi13 opened this issue Mar 2, 2023 · 3 comments · Fixed by #130
Closed

Duplicate class com.google.android.play.core.appupdate.AppUpdateInfo found in modules jetified-app-update-2.0.1-runtime #129

danielmessi13 opened this issue Mar 2, 2023 · 3 comments · Fixed by #130
Assignees
@Skyost
Labels
bug Something isn't working

Comments

@danielmessi13
Copy link
Contributor

Describe the bug
There is a deprecated implementation in build.gradle that conflicts with other packages that use updated implementations. I'm not sure that's the reason, but it appears to be.

The Play Core Java and Kotlin Library has been partitioned into multiple per-feature Android libraries. This reduces the size Play Core libraries add to your app and allows for faster release cycles of the individual features.

https://developer.android.com/guide/playcore#java-kotlin-in-app-review

To Reproduce
Steps to reproduce the behavior:

  1. Add in_app_update package
  2. Add rate_my_app package
  3. Try run in Android

Screenshots
image

Smartphone:

  • Device: Android Pixel 4
  • OS: Android 12
  • Version: API 31

Additional context
I did a test update and it worked:

change this:

implementation 'com.google.android.play:core:1.8.0'

to

implementation 'com.google.android.play:review:2.0.1'
implementation 'com.google.android.play:review-ktx:2.0.1'
@danielmessi13 danielmessi13 added the bug Something isn't working label Mar 2, 2023
@danielmessi13 danielmessi13 mentioned this issue Mar 2, 2023
Merged
@danielmessi13
Copy link
Contributor Author

I created a PR solving this, in case I see that it makes sense and doesn't bring any problems to the package

@Skyost

@lesonlhld
Copy link

Hello @Skyost,

I was wondering if it would be possible for you to release a new version on pub.dev to fix this problem. Thank you in advance for your help!

Best regards,

@Skyost
Copy link
Owner

Skyost commented Mar 9, 2023

Yes, for sure. I also have to release a new version of FlutterWeekView. I'll do it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skyost Skyost

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migration PlayCore to PlayReview danielmessi13/RateMyApp
3 participants
@Skyost @danielmessi13 @lesonlhld