Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trackable event incorrect when beforeId matched item being updated #207

Closed
edhager opened this issue Jun 1, 2017 · 0 comments · Fixed by #208
Closed

Trackable event incorrect when beforeId matched item being updated #207

edhager opened this issue Jun 1, 2017 · 0 comments · Fixed by #208
Assignees
Labels

Comments

@edhager
Copy link
Member

edhager commented Jun 1, 2017

This issue started with SitePen/dgrid#1365.

The problem is in dstore/Trackable. When a call to a trackable store's put method is updating an item using the beforeId option set to the item's id, the item is removed from Trackable's arrays.
This in turn caused the Trackable event that was generated to not have an index property.

store.put(store.getSync(1), { beforeId: 1 });
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant