New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type Glyph of FontSymbol? #156

Open

flyisland opened this issue Jun 11, 2024 · 1 comment

flyisland commented Jun 11, 2024

In the file https://github.com/Siedlerchr/types-ol-ext/blob/master/%40types/ol-ext/style/FontSymbol.d.ts, we have the below type Glyph:

export interface Glyph {
  font: string,
  char: number,
  theme: string,
  name: string,
  search: string
}

But the https://github.com/Viglino/ol-ext/blob/master/src/style/FontMakiDef.js and https://github.com/Viglino/ol-ext/blob/master/src/style/FontMaki2Def.js do not match the type of glyph. For example, these two files are missing the "char" key.

Owner

Siedlerchr commented Jun 18, 2024

Hm, this is odd. Maybe we can simply make all params as optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment