Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codemirror language client support for rename requests #492

Open
Tracked by #241
charlespwd opened this issue Sep 17, 2024 · 0 comments
Open
Tracked by #241

Add codemirror language client support for rename requests #492

charlespwd opened this issue Sep 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@charlespwd
Copy link
Contributor

charlespwd commented Sep 17, 2024 •
edited
Loading

Maybe this one I leave for later since we'll need a UI that overrides the right click. >.>

I anticipate a user flow like this:

  • User presses F2 or right click > show popup > Rename Symbol
  • User is prompted with field to change the name of the variable/tagname/whatever
  • User enters a new name, presses enter
  • CM sends Rename Request to Language Server
  • Language Server responds with a Workspace Edit
  • CM applies workspace edit to file
  • Thing is renamed is renamed

Missing design parts:

  • UI for Rename Symbol from right click
  • UI for Rename Symbol before sending request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charlespwd @mgmanzella