Identify missing calls to block.shopify_attributes

[samdoiron]

All rendered blocks should to use block.shopify_attributes like this

{% for block in sections.blocks %}
  <div {{ block.shopify_attributes }}></div>
{% endfor %}

This might be tricky to identify. Some cases would be caught by checking the contents of any for loops over section.blocks, but there are subtleties like the {% render .. for %} syntax.

[samdoiron]

This came up as an actually issue in one of our internal themes recently. We use these attributes to live-patch the DOM when settings like a linked image are updated.

[macournoyer]

👍 Appears to be documented here: https://shopify.dev/docs/themes/liquid/reference/objects/block#block-shopify_attributes.

Maybe we could check that as soon as sections.blocks is referenced in a template block.shopify_attributes is always present.

[charlespwd]

Don't know how we can do this reliably. I'm thinking of {% render %}, content_for blocks, {% case block.type %} and so on.