Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config files $schema validation errors #367

Open
madsenmm opened this issue Jun 12, 2024 · 3 comments
Open

Config files $schema validation errors #367

madsenmm opened this issue Jun 12, 2024 · 3 comments
Labels
Bug Something isn't working open for contributions theme bugs that won't be prioritized in the near future

Comments

@madsenmm
Copy link
Contributor

madsenmm commented Jun 12, 2024

Describe the bug
When editing typical config files like .json or .rc files, it throws errors when theres exists $schema property in the file.

Source

Message: Request textDocument/completion failed with message: Cannot read properties of undefined (reading '$schema')
Code: -32603

Expected behaviour
$schema property should be ignored, and only check on schema name

Actual behaviour
Throws unnecessary error

Debugging information

  • OS: Mac
  • OS Version: macOS Sonoma 14.5 (23F79)
  • Theme Check Version: Shopify CLI v. 3.61.0
@mgmanzella
Copy link
Contributor

thanks for reporting this issue, to clarify where are you seeing this error and what's happens after receiving it? that looks like an issue with language server and completions erroring out.

sharing exact example files and where they are in your theme directory would be helpful as well for debugging. thanks in advance 🙏

@madsenmm
Copy link
Contributor Author

@mgmanzella Were just editing a package.json file, nothing crucial of any format, just noticed the error, because there wre defined a $schema property, for JSON Schema helpers.

@mgmanzella mgmanzella added Bug Something isn't working open for contributions theme bugs that won't be prioritized in the near future labels Jun 19, 2024
@mgmanzella
Copy link
Contributor

got it, thanks for the context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working open for contributions theme bugs that won't be prioritized in the near future
Projects
None yet
Development

No branches or pull requests

2 participants