Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for blank environment variables #75

Open
technicalpickles opened this issue Jan 24, 2024 · 0 comments · May be fixed by #76
Open

Check for blank environment variables #75

technicalpickles opened this issue Jan 24, 2024 · 0 comments · May be fixed by #76

Comments

@technicalpickles
Copy link

I was pairing with @wildmaples to add this to our CI, and it was failing with:

read:0x00007f579f41cb18 /usr/local/bundle/ruby/3.2.0/gems/smart_todo-1.7.0/lib/smart_todo/cli.rb:121 run> terminated with exception (report_on_exception is true):
--
  | /usr/local/bundle/ruby/3.2.0/gems/smart_todo-1.7.0/lib/smart_todo/slack_client.rb:97:in `slack_response!': Response body: {"ok"=>false, "error"=>"not_authed"} (SmartTodo::SlackClient::Error)

It turned out we were setting SMART_TODO_SLACK_TOKEN, but it was evaluating to an empty string 🙊 . I think it's a simple adjustmen to check for it to be non-empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check that slack token isn't empty before using it technicalpickles/smart_todo
1 participant
@technicalpickles